[GitHub] [incubator-inlong] yunqingmoswu commented on a diff in pull request #4450: [INLONG-4448][Sort] Add Greenplum database data load support

[GitBox <gi...@apache.org>]

yunqingmoswu commented on code in PR #4450:
URL: https://github.com/apache/incubator-inlong/pull/4450#discussion_r885293772


##########
inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/table/JdbcDialects.java:
##########
@@ -54,13 +58,22 @@ public static Optional<JdbcDialect> get(String url) {
         return Optional.empty();
     }
 
+    public static Optional<JdbcDialect> getCustomDialect(String dialectImpl) {

Review Comment:
   The user does not need to perceive the difference between the two, but if the user specifies a certain dialect, we must use this dialect, and this effect cannot be achieved only by get, because the url may be the same.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org