You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/09/01 12:55:34 UTC

[GitHub] [avro] RyanSkraba commented on a diff in pull request #1843: AVRO-3622 (python) Fix compatibility check for schemas having or missing namespace

RyanSkraba commented on code in PR #1843:
URL: https://github.com/apache/avro/pull/1843#discussion_r960619608


##########
lang/py/avro/test/test_schema.py:
##########
@@ -629,6 +641,10 @@ def test_invalid_name(self):
             None,
             None,
         )
+        # A name cannot start with dot."

Review Comment:
   To be very clear : `.Abc` is not currently a supported fullname.   Best practice strongly suggests that you don't use an unqualified name in a nested named schema.  Today, you're likely to run into undefined and unexpected behaviour if you you do!
   
   That can of worms needs to be solved but not necessarily in this PR...
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org