[GitHub] incubator-storm pull request: Testing: allow users to pass TEST-TI...

[revans2 <gi...@git.apache.org>]

Github user revans2 commented on the pull request:

    https://github.com/apache/incubator-storm/pull/122#issuecomment-45096868
  
    All pull requests need a JIRA associated with them.  Could you please file a JIRA if one does not already exist and update the title of this pull request to have the JIRA number in it, i.e. STORM-12345.
    
    The code itself looks fine to me.  But I would almost rather have a second defined timeout that is based off of the original timeout.  Simply because in complete-topology simulate-wait within a loop.  simulate-wait also has the same timeout code in it but in a loop 10 times, so if you get unlucky and get close to the timeout even once in simulate-wait the outer loop will timeout.  We could simply have it be 3 * TEST-TIMEOUT-MS


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---