[GitHub] [helix] kaisun2000 commented on pull request #1138: Cleanup test code and adding finalize method to avoid ZkClient leakage in the Helix-core tests.

[GitBox <gi...@apache.org>]

kaisun2000 commented on pull request #1138:
URL: https://github.com/apache/helix/pull/1138#issuecomment-657791412


   Twe question/comments:
   
   1/ Is this inclusive for closing all these objects to prevent leaking zookeeper client?
   
   2/ relying on finalized means that the objects are only closed when GC happens. This is not ideal. I understand we want a quick fix for now. Will enhance it later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org