You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by lp...@apache.org on 2023/07/31 23:01:38 UTC
[shiro] branch dependabot/maven/com.puppycrawl.tools-checkstyle-10.12.2 updated (4728b6be7 -> cde245ad3)
This is an automated email from the ASF dual-hosted git repository.
lprimak pushed a change to branch dependabot/maven/com.puppycrawl.tools-checkstyle-10.12.2
in repository https://gitbox.apache.org/repos/asf/shiro.git
omit 4728b6be7 enh(checkstyle): made private classes final to conform to latest checkstyle rules
new cde245ad3 enh(checkstyle): made private classes final to conform to latest checkstyle rules
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (4728b6be7)
\
N -- N -- N refs/heads/dependabot/maven/com.puppycrawl.tools-checkstyle-10.12.2 (cde245ad3)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../src/test/java/org/apache/shiro/testing/jaxrs/NoIniJaxRsIT.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[shiro] 01/01: enh(checkstyle): made private classes final to conform to latest checkstyle rules
Posted by lp...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
lprimak pushed a commit to branch dependabot/maven/com.puppycrawl.tools-checkstyle-10.12.2
in repository https://gitbox.apache.org/repos/asf/shiro.git
commit cde245ad38495e1cac1f498c0c7af498a5b205d3
Author: lprimak <le...@flowlogix.com>
AuthorDate: Mon Jul 31 18:01:22 2023 -0500
enh(checkstyle): made private classes final to conform to latest checkstyle rules
---
.../java/org/apache/shiro/testing/jaxrs/NoIniJaxRsIT.java | 2 +-
.../java/org/apache/shiro/cdi/AnnotatedTypeWrapperTest.java | 8 ++++----
.../org/apache/shiro/ee/cdi/ShiroSessionScopeExtension.java | 12 ++++++------
.../apache/shiro/ee/filters/FormAuthenticationFilter.java | 2 +-
.../main/java/org/apache/shiro/ee/filters/LogoutFilter.java | 2 +-
.../shiro/ee/filters/PassThruAuthenticationFilter.java | 2 +-
.../java/org/apache/shiro/ee/listeners/IniEnvironment.java | 2 +-
.../java/org/apache/shiro/ee/cdi/ShiroScopeContextTest.java | 2 +-
8 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/integration-tests/jakarta-ee/src/test/java/org/apache/shiro/testing/jaxrs/NoIniJaxRsIT.java b/integration-tests/jakarta-ee/src/test/java/org/apache/shiro/testing/jaxrs/NoIniJaxRsIT.java
index 60cb70137..48537d2b1 100644
--- a/integration-tests/jakarta-ee/src/test/java/org/apache/shiro/testing/jaxrs/NoIniJaxRsIT.java
+++ b/integration-tests/jakarta-ee/src/test/java/org/apache/shiro/testing/jaxrs/NoIniJaxRsIT.java
@@ -38,7 +38,7 @@ import org.junit.jupiter.api.extension.ExtendWith;
@ExtendWith(ArquillianExtension.class)
public class NoIniJaxRsIT {
@Builder
- private static class Credentials {
+ private static final class Credentials {
final boolean send;
final String username;
final String password;
diff --git a/support/cdi/src/test/java/org/apache/shiro/cdi/AnnotatedTypeWrapperTest.java b/support/cdi/src/test/java/org/apache/shiro/cdi/AnnotatedTypeWrapperTest.java
index c643bdc41..917cee4d8 100644
--- a/support/cdi/src/test/java/org/apache/shiro/cdi/AnnotatedTypeWrapperTest.java
+++ b/support/cdi/src/test/java/org/apache/shiro/cdi/AnnotatedTypeWrapperTest.java
@@ -44,17 +44,17 @@ class AnnotatedTypeWrapperTest {
@RequiresAuthentication
@RequiresGuest
@RequiresPermissions("hello")
- private class Annotated { }
+ private final class Annotated { }
@ShiroSecureAnnotation
- private class ShiroSecureAnnotated { }
+ private final class ShiroSecureAnnotated { }
@Stateless
- private class StatelessAnnotated { }
+ private final class StatelessAnnotated { }
@SessionScoped
@SuppressWarnings("serial")
- private static class SessionScopedAnnotated implements Serializable { }
+ private static final class SessionScopedAnnotated implements Serializable { }
@Test
void noAnnotations() {
diff --git a/support/jakarta-ee/src/main/java/org/apache/shiro/ee/cdi/ShiroSessionScopeExtension.java b/support/jakarta-ee/src/main/java/org/apache/shiro/ee/cdi/ShiroSessionScopeExtension.java
index dbadd6b61..9ad3386e9 100644
--- a/support/jakarta-ee/src/main/java/org/apache/shiro/ee/cdi/ShiroSessionScopeExtension.java
+++ b/support/jakarta-ee/src/main/java/org/apache/shiro/ee/cdi/ShiroSessionScopeExtension.java
@@ -46,23 +46,23 @@ public class ShiroSessionScopeExtension implements Extension, Serializable {
@SessionScoped
@SuppressWarnings("serial")
- private static class SessionScopedAnnotated implements Serializable { }
+ private static final class SessionScopedAnnotated implements Serializable { }
@javax.faces.view.ViewScoped
@SuppressWarnings("serial")
- private static class FacesViewScopedAnnotated implements Serializable { }
+ private static final class FacesViewScopedAnnotated implements Serializable { }
@org.omnifaces.cdi.ViewScoped
@SuppressWarnings("serial")
- private static class OmniViewScopedAnnotated implements Serializable { }
+ private static final class OmniViewScopedAnnotated implements Serializable { }
@ShiroSessionScoped
@SuppressWarnings("serial")
- private static class ShiroSessionScopedAnnotated implements Serializable { }
+ private static final class ShiroSessionScopedAnnotated implements Serializable { }
@ShiroFacesViewScoped
@SuppressWarnings("serial")
- private static class ShiroFacesViewScopedAnnotated implements Serializable { }
+ private static final class ShiroFacesViewScopedAnnotated implements Serializable { }
@ShiroOmniViewScoped
@SuppressWarnings("serial")
- private static class ShiroOmniViewScopedAnnotated implements Serializable { }
+ private static final class ShiroOmniViewScopedAnnotated implements Serializable { }
/**
diff --git a/support/jakarta-ee/src/main/java/org/apache/shiro/ee/filters/FormAuthenticationFilter.java b/support/jakarta-ee/src/main/java/org/apache/shiro/ee/filters/FormAuthenticationFilter.java
index 0dc7582d7..a65b4c0dc 100644
--- a/support/jakarta-ee/src/main/java/org/apache/shiro/ee/filters/FormAuthenticationFilter.java
+++ b/support/jakarta-ee/src/main/java/org/apache/shiro/ee/filters/FormAuthenticationFilter.java
@@ -38,7 +38,7 @@ public class FormAuthenticationFilter extends org.apache.shiro.web.filter.authc.
static final FallbackPredicate NO_PREDICATE = (path, request) -> false;
private final @Delegate AuthenticationFilterDelegate delegate;
- private class Methods implements MethodsFromFilter {
+ private final class Methods implements MethodsFromFilter {
@Override
public Subject getSubject(ServletRequest request, ServletResponse response) {
return FormAuthenticationFilter.super.getSubject(request, response);
diff --git a/support/jakarta-ee/src/main/java/org/apache/shiro/ee/filters/LogoutFilter.java b/support/jakarta-ee/src/main/java/org/apache/shiro/ee/filters/LogoutFilter.java
index 06d43dd11..ed54b7731 100644
--- a/support/jakarta-ee/src/main/java/org/apache/shiro/ee/filters/LogoutFilter.java
+++ b/support/jakarta-ee/src/main/java/org/apache/shiro/ee/filters/LogoutFilter.java
@@ -33,7 +33,7 @@ public class LogoutFilter extends org.apache.shiro.web.filter.authc.LogoutFilter
static final String LOGOUT_PREDICATE_ATTR_NAME = "org.apache.shiro.ee.logout-predicate";
private final @Delegate AuthenticationFilterDelegate delegate;
- private class Methods implements MethodsFromFilter {
+ private final class Methods implements MethodsFromFilter {
@Override
public Subject getSubject(ServletRequest request, ServletResponse response) {
return LogoutFilter.super.getSubject(request, response);
diff --git a/support/jakarta-ee/src/main/java/org/apache/shiro/ee/filters/PassThruAuthenticationFilter.java b/support/jakarta-ee/src/main/java/org/apache/shiro/ee/filters/PassThruAuthenticationFilter.java
index 0a9402d21..00318874c 100644
--- a/support/jakarta-ee/src/main/java/org/apache/shiro/ee/filters/PassThruAuthenticationFilter.java
+++ b/support/jakarta-ee/src/main/java/org/apache/shiro/ee/filters/PassThruAuthenticationFilter.java
@@ -30,7 +30,7 @@ import org.apache.shiro.subject.Subject;
public class PassThruAuthenticationFilter extends org.apache.shiro.web.filter.authc.PassThruAuthenticationFilter {
private final @Delegate AuthenticationFilterDelegate delegate;
- private class Methods implements MethodsFromFilter {
+ private final class Methods implements MethodsFromFilter {
@Override
public Subject getSubject(ServletRequest request, ServletResponse response) {
return PassThruAuthenticationFilter.super.getSubject(request, response);
diff --git a/support/jakarta-ee/src/main/java/org/apache/shiro/ee/listeners/IniEnvironment.java b/support/jakarta-ee/src/main/java/org/apache/shiro/ee/listeners/IniEnvironment.java
index 512a1399b..d38ef7dff 100644
--- a/support/jakarta-ee/src/main/java/org/apache/shiro/ee/listeners/IniEnvironment.java
+++ b/support/jakarta-ee/src/main/java/org/apache/shiro/ee/listeners/IniEnvironment.java
@@ -40,7 +40,7 @@ public class IniEnvironment extends IniWebEnvironment {
private String otherConfigLocation;
@SuppressWarnings("deprecation")
- private static class SecurityManagerFactory extends WebIniSecurityManagerFactory {
+ private static final class SecurityManagerFactory extends WebIniSecurityManagerFactory {
private final Lazy<AesCipherService> cipherService = new Lazy<>(AesCipherService::new);
@Override
diff --git a/support/jakarta-ee/src/test/java/org/apache/shiro/ee/cdi/ShiroScopeContextTest.java b/support/jakarta-ee/src/test/java/org/apache/shiro/ee/cdi/ShiroScopeContextTest.java
index 3241ea123..003a6408f 100644
--- a/support/jakarta-ee/src/test/java/org/apache/shiro/ee/cdi/ShiroScopeContextTest.java
+++ b/support/jakarta-ee/src/test/java/org/apache/shiro/ee/cdi/ShiroScopeContextTest.java
@@ -56,7 +56,7 @@ public class ShiroScopeContextTest {
private MyBean bean;
private ShiroScopeContext ctx;
- private static class MyBean implements ViewScoped, Serializable {
+ private static final class MyBean implements ViewScoped, Serializable {
private static final long serialVersionUID = 1L;
@Override