You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Lucas Holmquist <lh...@redhat.com> on 2013/08/05 21:36:26 UTC
add "about" command to CLI
https://issues.apache.org/jira/browse/CB-2234
has there been any work done on this? I would like to take this one. I've been meaning to start contributing, but things keep coming up, so i figured this would be a good step to start with
-Luke
Re: add "about" command to CLI
Posted by Lucas Holmquist <lh...@redhat.com>.
On Aug 6, 2013, at 7:45 PM, Anis KADRI <an...@gmail.com> wrote:
> Just tried it and it works. I have a couple of comments.
>
> - I think it would be better to have a separate template and then use
> util.format() to add all the values. Kinda like we do help()
i made some updates to work somewhat like help(). although i didn't see any until.format() there
https://github.com/lholmquist/cordova-cli/tree/CB-2234
the formatting is a little off in parts, but wanted some more feedback before i sent the PR
also tests have been added
> - I think you should add some tests ;-}
>
>
>
> On Tue, Aug 6, 2013 at 2:11 PM, Lucas Holmquist <lh...@redhat.com> wrote:
>> oh yea, and the command is "cordova -i" or "cordova -info"
>> On Aug 6, 2013, at 5:10 PM, Lucas Holmquist <lh...@redhat.com> wrote:
>>
>>> So i've done a little work on this here:
>>>
>>> https://github.com/lholmquist/cordova-cli/tree/CB-2234
>>>
>>> atm i've only added the iOS and Android platforms. And it doesn't currently get your command history.
>>>
>>> i have it outputting to the console as well as writing to a file, info.txt , eventually maybe just go with the file.
>>>
>>> wanted to get some feedback before i sent the PR in
>>>
>>> On Aug 5, 2013, at 3:42 PM, Lucas Holmquist <lh...@redhat.com> wrote:
>>>
>>>>
>>>> On Aug 5, 2013, at 3:38 PM, Anis KADRI <an...@gmail.com> wrote:
>>>>
>>>>> Do it! :)
>>>> i will, looks like i can't assign to myself however, commented in the JIRA
>>>>
>>>>>
>>>>> On Mon, Aug 5, 2013 at 12:36 PM, Lucas Holmquist <lh...@redhat.com> wrote:
>>>>>> https://issues.apache.org/jira/browse/CB-2234
>>>>>>
>>>>>> has there been any work done on this? I would like to take this one. I've been meaning to start contributing, but things keep coming up, so i figured this would be a good step to start with
>>>>>>
>>>>>> -Luke
>>>>
>>>
>>
Re: add "about" command to CLI
Posted by Lucas Holmquist <lh...@redhat.com>.
On Aug 6, 2013, at 7:45 PM, Anis KADRI <an...@gmail.com> wrote:
> Just tried it and it works. I have a couple of comments.
>
> - I think it would be better to have a separate template and then use
> util.format() to add all the values. Kinda like we do help()
thanks for the feedback, i figured there was an easier way
> - I think you should add some tests ;-}
tests? what are tests? ;)
>
>
>
> On Tue, Aug 6, 2013 at 2:11 PM, Lucas Holmquist <lh...@redhat.com> wrote:
>> oh yea, and the command is "cordova -i" or "cordova -info"
>> On Aug 6, 2013, at 5:10 PM, Lucas Holmquist <lh...@redhat.com> wrote:
>>
>>> So i've done a little work on this here:
>>>
>>> https://github.com/lholmquist/cordova-cli/tree/CB-2234
>>>
>>> atm i've only added the iOS and Android platforms. And it doesn't currently get your command history.
>>>
>>> i have it outputting to the console as well as writing to a file, info.txt , eventually maybe just go with the file.
>>>
>>> wanted to get some feedback before i sent the PR in
>>>
>>> On Aug 5, 2013, at 3:42 PM, Lucas Holmquist <lh...@redhat.com> wrote:
>>>
>>>>
>>>> On Aug 5, 2013, at 3:38 PM, Anis KADRI <an...@gmail.com> wrote:
>>>>
>>>>> Do it! :)
>>>> i will, looks like i can't assign to myself however, commented in the JIRA
>>>>
>>>>>
>>>>> On Mon, Aug 5, 2013 at 12:36 PM, Lucas Holmquist <lh...@redhat.com> wrote:
>>>>>> https://issues.apache.org/jira/browse/CB-2234
>>>>>>
>>>>>> has there been any work done on this? I would like to take this one. I've been meaning to start contributing, but things keep coming up, so i figured this would be a good step to start with
>>>>>>
>>>>>> -Luke
>>>>
>>>
>>
Re: add "about" command to CLI
Posted by Anis KADRI <an...@gmail.com>.
Just tried it and it works. I have a couple of comments.
- I think it would be better to have a separate template and then use
util.format() to add all the values. Kinda like we do help()
- I think you should add some tests ;-}
On Tue, Aug 6, 2013 at 2:11 PM, Lucas Holmquist <lh...@redhat.com> wrote:
> oh yea, and the command is "cordova -i" or "cordova -info"
> On Aug 6, 2013, at 5:10 PM, Lucas Holmquist <lh...@redhat.com> wrote:
>
>> So i've done a little work on this here:
>>
>> https://github.com/lholmquist/cordova-cli/tree/CB-2234
>>
>> atm i've only added the iOS and Android platforms. And it doesn't currently get your command history.
>>
>> i have it outputting to the console as well as writing to a file, info.txt , eventually maybe just go with the file.
>>
>> wanted to get some feedback before i sent the PR in
>>
>> On Aug 5, 2013, at 3:42 PM, Lucas Holmquist <lh...@redhat.com> wrote:
>>
>>>
>>> On Aug 5, 2013, at 3:38 PM, Anis KADRI <an...@gmail.com> wrote:
>>>
>>>> Do it! :)
>>> i will, looks like i can't assign to myself however, commented in the JIRA
>>>
>>>>
>>>> On Mon, Aug 5, 2013 at 12:36 PM, Lucas Holmquist <lh...@redhat.com> wrote:
>>>>> https://issues.apache.org/jira/browse/CB-2234
>>>>>
>>>>> has there been any work done on this? I would like to take this one. I've been meaning to start contributing, but things keep coming up, so i figured this would be a good step to start with
>>>>>
>>>>> -Luke
>>>
>>
>
Re: add "about" command to CLI
Posted by Lucas Holmquist <lh...@redhat.com>.
oh yea, and the command is "cordova -i" or "cordova -info"
On Aug 6, 2013, at 5:10 PM, Lucas Holmquist <lh...@redhat.com> wrote:
> So i've done a little work on this here:
>
> https://github.com/lholmquist/cordova-cli/tree/CB-2234
>
> atm i've only added the iOS and Android platforms. And it doesn't currently get your command history.
>
> i have it outputting to the console as well as writing to a file, info.txt , eventually maybe just go with the file.
>
> wanted to get some feedback before i sent the PR in
>
> On Aug 5, 2013, at 3:42 PM, Lucas Holmquist <lh...@redhat.com> wrote:
>
>>
>> On Aug 5, 2013, at 3:38 PM, Anis KADRI <an...@gmail.com> wrote:
>>
>>> Do it! :)
>> i will, looks like i can't assign to myself however, commented in the JIRA
>>
>>>
>>> On Mon, Aug 5, 2013 at 12:36 PM, Lucas Holmquist <lh...@redhat.com> wrote:
>>>> https://issues.apache.org/jira/browse/CB-2234
>>>>
>>>> has there been any work done on this? I would like to take this one. I've been meaning to start contributing, but things keep coming up, so i figured this would be a good step to start with
>>>>
>>>> -Luke
>>
>
Re: add "about" command to CLI
Posted by Lucas Holmquist <lh...@redhat.com>.
So i've done a little work on this here:
https://github.com/lholmquist/cordova-cli/tree/CB-2234
atm i've only added the iOS and Android platforms. And it doesn't currently get your command history.
i have it outputting to the console as well as writing to a file, info.txt , eventually maybe just go with the file.
wanted to get some feedback before i sent the PR in
On Aug 5, 2013, at 3:42 PM, Lucas Holmquist <lh...@redhat.com> wrote:
>
> On Aug 5, 2013, at 3:38 PM, Anis KADRI <an...@gmail.com> wrote:
>
>> Do it! :)
> i will, looks like i can't assign to myself however, commented in the JIRA
>
>>
>> On Mon, Aug 5, 2013 at 12:36 PM, Lucas Holmquist <lh...@redhat.com> wrote:
>>> https://issues.apache.org/jira/browse/CB-2234
>>>
>>> has there been any work done on this? I would like to take this one. I've been meaning to start contributing, but things keep coming up, so i figured this would be a good step to start with
>>>
>>> -Luke
>
Re: add "about" command to CLI
Posted by Lucas Holmquist <lh...@redhat.com>.
On Aug 5, 2013, at 3:38 PM, Anis KADRI <an...@gmail.com> wrote:
> Do it! :)
i will, looks like i can't assign to myself however, commented in the JIRA
>
> On Mon, Aug 5, 2013 at 12:36 PM, Lucas Holmquist <lh...@redhat.com> wrote:
>> https://issues.apache.org/jira/browse/CB-2234
>>
>> has there been any work done on this? I would like to take this one. I've been meaning to start contributing, but things keep coming up, so i figured this would be a good step to start with
>>
>> -Luke
Re: add "about" command to CLI
Posted by Anis KADRI <an...@gmail.com>.
Do it! :)
On Mon, Aug 5, 2013 at 12:36 PM, Lucas Holmquist <lh...@redhat.com> wrote:
> https://issues.apache.org/jira/browse/CB-2234
>
> has there been any work done on this? I would like to take this one. I've been meaning to start contributing, but things keep coming up, so i figured this would be a good step to start with
>
> -Luke