[GitHub] quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

[GitBox <gi...@apache.org>]

quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test
URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238313448
 
 

 ##########
 File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java
 ##########
 @@ -391,12 +391,12 @@ public static void main(String[] args) {
       me.end();
     } catch (Exception e) {
       HelpFormatter formatter = new HelpFormatter();
-      formatter.printHelp("MudrodEngine: 'dataDir' argument is mandatory. " + "User must also provide an ingest method.", true);
+      formatter.printHelp("MudrodEngine: 'dataDir' argument is mandatory. " + "User must also provide an ingest method.", options, true);
       LOG.error("Error whilst parsing command line.", e);
     }
   }
 
-  private static void loadPathConfig(MudrodEngine me, String dataDir) {
+  public static void loadPathConfig(MudrodEngine me, String dataDir) {
 
 Review comment:
   loadPathConfig is invoked outside MudrodEngine in the test code. https://github.com/quintinali/incubator-sdap-mudrod/blob/b3ef470a39f8df68ddf80805c6948f870feeb2ce/core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java#L31

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services