[GitHub] [guacamole-server] Saiyeux commented on a diff in pull request #404: GUACAMOLE-1632: Have spaces written in the appended clipboard.

[GitBox <gi...@apache.org>]

Saiyeux commented on code in PR #404:
URL: https://github.com/apache/guacamole-server/pull/404#discussion_r1029939210


##########
src/terminal/select.c:
##########
@@ -297,6 +297,13 @@ static void guac_terminal_clipboard_append_row(guac_terminal* terminal,
     if (end < 0 || end > buffer_row->length - 1)
         end = buffer_row->length - 1;
 
+    int j = end;
+    while((!buffer_row->characters[j].value)&& (j > start)){
+        j--;
+    }
+    if(j != start)

Review Comment:
   Sure, I'll mark some annotations on it and re-format. After investigating we assume that this problem is due to both vim specific behavior and guaca's display & copy logic.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org