[GitHub] [lucene-solr-operator] HoustonPutman commented on a change in pull request #231: Add conditional dependency for zk-operator helm chart

[GitBox <gi...@apache.org>]

HoustonPutman commented on a change in pull request #231:
URL: https://github.com/apache/lucene-solr-operator/pull/231#discussion_r588764883



##########
File path: helm/solr-operator/Chart.yaml
##########
@@ -95,4 +95,10 @@ annotations:
             name: "example"
         numThreads: 4
         image:
-          tag: 8.7.0
\ No newline at end of file
+          tag: 8.7.0
+
+dependencies:
+  - name: 'zookeeper-operator'
+    version: 0.2.9
+    repository: https://charts.pravega.io
+    condition: useZkOperator

Review comment:
       We probably want to change this to a different variable, such as `zookeeper-operator.enabled`, because we want users to be able to use the zookeeper-operator, without installing it as a dependency. That requires two variables. Then when setting the command line variable for solr, we can do an OR of `zookeeper-operator.enabled` and `useZkOperator`.
   
   I'm flexible on names, if you don't think that's clear.

##########
File path: config/dependencies/zk_operator.yaml
##########
@@ -0,0 +1,37 @@
+apiVersion: apiextensions.k8s.io/v1beta1

Review comment:
       This should be the v0.2.9 version:
   
   https://github.com/pravega/zookeeper-operator/blob/v0.2.9/deploy/crds/zookeeper.pravega.io_zookeeperclusters_crd.yaml




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org