You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/02/27 06:35:00 UTC
[jira] [Commented] (KAFKA-8007) In-memory window store copies on
fetch
[ https://issues.apache.org/jira/browse/KAFKA-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778960#comment-16778960 ]
ASF GitHub Bot commented on KAFKA-8007:
---------------------------------------
ableegoldman commented on pull request #6335: KAFKA-8007: Avoid copying on fetch in InMemoryWindowStore
URL: https://github.com/apache/kafka/pull/6335
Rewrote the InMemoryWindowStore implementation by moving the work of a fetch to the iterator, and cleaned up the iterators as well.
Blocked by [KAFKA-7918](https://github.com/apache/kafka/pull/6328)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> In-memory window store copies on fetch
> --------------------------------------
>
> Key: KAFKA-8007
> URL: https://issues.apache.org/jira/browse/KAFKA-8007
> Project: Kafka
> Issue Type: Improvement
> Reporter: Sophie Blee-Goldman
> Assignee: Sophie Blee-Goldman
> Priority: Major
>
> The current implementation of InMemoryWindowStore copies all record data into a new list and returns an iterator over that list when fetching. That is inefficient in terms of both memory and time. The fetching logic should be moved to the iterators, which could be cleaned up as well (currently they rely on ListIterator to provide peekNextKey() functionality, which is unnecessary).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)