You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/11/26 04:52:26 UTC

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #572: [IOTDB-309] change docker.

jixuan1989 commented on a change in pull request #572: [IOTDB-309] change docker.
URL: https://github.com/apache/incubator-iotdb/pull/572#discussion_r350542859
 
 

 ##########
 File path: docker/Dockerfile
 ##########
 @@ -28,22 +28,21 @@ RUN apt update \
   && wget https://github.com/apache/incubator-iotdb/archive/master.zip \
   && unzip master.zip \
   && rm master.zip \
-  && cd incubator-iotdb-master \
-  && mvn package -pl server,client -am -Papache-release -DskipTests -Dthrift.download-url="http://www.apache.org/licenses/LICENSE-2.0.txt" -Dthrift.exec.absolute.path="/usr/bin/thrift" \
-  && cd target/ \
-  && unzip apache-iotdb-0.9.0-SNAPSHOT-incubating-bin.zip \
-  && mkdir /iotdb \
-  && mv apache-iotdb-0.9.0-SNAPSHOT-incubating/* /iotdb/ \
-  && cd ../../ \
-  && mvn clean \
+WORKDIR incubator-iotdb-master
+RUN mvn package -Papache-release -DskipTests -Dthrift.download-url="http://www.apache.org/licenses/LICENSE-2.0.txt" -Dthrift.exec.absolute.path="/usr/bin/thrift"
+WORKDIR distributation/target/apache-iotdb-0.9.0-SNAPSHOT-incubating-bin/apache-iotdb-0.9.0-SNAPSHOT-incubating/
+RUN mkdir /iotdb \
+  && mv * /iotdb/ \
+WORKDIR /incubator-iotdb-master
+RUN mvn clean \
   && ls -lh ~/.m2 \
   && rm -rf ~/.m2 \
   && rm -rf /incubator-iotdb-master \
   && sed -i '119d' /iotdb/conf/logback.xml \
-  && apt remove wget maven unzip thrift-compiler -y \
-  && apt autoremove -y \
-  && apt purge --auto-remove -y \
-  && apt clean -y 
+  && apt-get remove wget maven unzip thrift-compiler -y \
+  && apt-get autoremove -y \
+  && apt-get purge --auto-remove -y \
+  && apt-get clean -y
 ENV JAVA_HOME  "/jdk-11.0.2"
 ENV PATH "$JAVA_HOME/bin:$PATH"
 EXPOSE 6667
 
 Review comment:
   and we need to 
   EXPOSE 31999

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services