You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Kevin Pilch-Bisson <ke...@pilch-bisson.net> on 2002/03/11 13:46:31 UTC
svn log doesn't work.
On Friday Ben Collins, Garrett, and I noticed that there is a bug in svn log
when single directory is specified. After looking into it, I found that the
problem is that we call svn_path_condense_targets which returns the dir as the
basename (where we anchor the operation), and nothing for the paths. (As
promised by its docstring). However, due to the code structure, this means
that we never call svn_fs_revisions_changed on the path, and we end up
displaying the log message for every revision.
Try
svn log packages/freebsd
compared with
svn log packages/freebsd subversion/clients/win32/svn_com
In the second case it works right because basename is "." and we call
svn_fs_revisions_changed on the two paths.
I've looked into it a bit, and can't quite figure out how to fix this, but if
anyone else has an idea, speak up.
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson http://www.pilch-bisson.net
"Historically speaking, the presences of wheels in Unix
has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Re: svn log doesn't work.
Posted by Kevin Pilch-Bisson <ke...@pilch-bisson.net>.
On Mon, Mar 11, 2002 at 09:10:35AM -0600, cmpilato@collab.net wrote:
> Kevin Pilch-Bisson <ke...@pilch-bisson.net> writes:
>
> > Nevermind fixed in rev 1481.
> >
> > Too bad svn.collab.net doesn't have it.
>
> Wanna bet? ;-)
>
Thanks Mike!
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson http://www.pilch-bisson.net
"Historically speaking, the presences of wheels in Unix
has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Re: svn log doesn't work.
Posted by cm...@collab.net.
Kevin Pilch-Bisson <ke...@pilch-bisson.net> writes:
> Nevermind fixed in rev 1481.
>
> Too bad svn.collab.net doesn't have it.
Wanna bet? ;-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn log doesn't work.
Posted by Kevin Pilch-Bisson <ke...@pilch-bisson.net>.
Nevermind fixed in rev 1481.
Too bad svn.collab.net doesn't have it.
I also wanted to point out that because of the bubble-up nature of commits in
svn, we automatically get svn log dirname functionality whereby all revisions
in which dirname or its children changed are reported.
On Mon, Mar 11, 2002 at 08:46:31AM -0500, Kevin Pilch-Bisson wrote:
> On Friday Ben Collins, Garrett, and I noticed that there is a bug in svn log
> when single directory is specified. After looking into it, I found that the
> problem is that we call svn_path_condense_targets which returns the dir as the
> basename (where we anchor the operation), and nothing for the paths. (As
> promised by its docstring). However, due to the code structure, this means
> that we never call svn_fs_revisions_changed on the path, and we end up
> displaying the log message for every revision.
>
> Try
> svn log packages/freebsd
> compared with
> svn log packages/freebsd subversion/clients/win32/svn_com
>
> In the second case it works right because basename is "." and we call
> svn_fs_revisions_changed on the two paths.
>
> I've looked into it a bit, and can't quite figure out how to fix this, but if
> anyone else has an idea, speak up.
> --
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Kevin Pilch-Bisson http://www.pilch-bisson.net
> "Historically speaking, the presences of wheels in Unix
> has never precluded their reinvention." - Larry Wall
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson http://www.pilch-bisson.net
"Historically speaking, the presences of wheels in Unix
has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~