You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "dao-jun (via GitHub)" <gi...@apache.org> on 2024/04/25 07:08:21 UTC

Re: [PR] [pulsar-broker] schedule one add/read timeout task per ml/topic [pulsar]

dao-jun commented on PR #4111:
URL: https://github.com/apache/pulsar/pull/4111#issuecomment-2076515656

   @rdhabalia Hi, I noticed we only introduced a single `lastReadCallback` field to store the ongoing read operations, does it mean we only check the last read operation is timeout or not?
   
   For instance, there is a read operation A, we will set `lastReadCallback`  to A, and check if it is timeout. But at the next second, there is another read operation B, `lastReadCallback`  will set to B even A is not finished. So finally, we just check B is timeout or not, A is covered by B.
   
   Is there something else I don't understand or a bug?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org