You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/03/18 21:58:19 UTC
[PR] build with protoc 3.25.3 [incubator-pekko]
pjfanning opened a new pull request, #1209:
URL: https://github.com/apache/incubator-pekko/pull/1209
matches the protobuf-java version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] build with protoc 3.25.3 [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #1209:
URL: https://github.com/apache/incubator-pekko/pull/1209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] build with protoc 3.25.3 [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1209:
URL: https://github.com/apache/incubator-pekko/pull/1209#discussion_r1530101212
##########
project/Protobuf.scala:
##########
@@ -40,7 +40,7 @@ object Protobuf {
// this keeps intellij happy for files that use the shaded protobuf
Compile / unmanagedJars += (LocalProject("protobuf-v3") / Compile / packageBin).value,
protoc := "protoc",
- protocVersion := "3.20.3",
+ protocVersion := "3.25.3",
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] build with protoc 3.25.3 [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1209:
URL: https://github.com/apache/incubator-pekko/pull/1209#discussion_r1529618185
##########
project/Protobuf.scala:
##########
@@ -40,7 +40,7 @@ object Protobuf {
// this keeps intellij happy for files that use the shaded protobuf
Compile / unmanagedJars += (LocalProject("protobuf-v3") / Compile / packageBin).value,
protoc := "protoc",
- protocVersion := "3.20.3",
+ protocVersion := "3.25.3",
Review Comment:
How about move the version to Dependencies.scala?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org