You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/12/20 14:29:42 UTC

[GitHub] zentol opened a new pull request #7346: [FLINK-11134][rest] Do not log stacktrace handled exceptions

zentol opened a new pull request #7346: [FLINK-11134][rest] Do not log stacktrace handled exceptions
URL: https://github.com/apache/flink/pull/7346
 
 
   ## What is the purpose of the change
   
   With this PR we do not log the full stacktrace for REST exception, under the conditions that
   1. DEBUG logging is disabled
   2. the exception is considered handled (i.e. is a RestHandlerException)
   
   For these exceptions the exception message is _usually_ sufficient to find out what's wrong; after all this is the only thing that users of the REST API get back as well.
   
   As an opt-out mechanism DEBUG logging can be enabled, just to be safe.
   Unhandled exceptions are excluded from this, as for these we cannot make any guarantee about the value of the error message.
   
   ## Brief change log
   
   * modify AbstractRestHandler to only log the exception stack trace if debug logging is enabled
   * add logging of exceptions in `AbstractHandler` `try-catch` block
     * remove 2 redundant logging statements in the AbstractHandler
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services