You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/25 06:26:58 UTC

[GitHub] [bookkeeper] zymap opened a new pull request #3139: Add memory limiter for the add entry request to avoid OOM

zymap opened a new pull request #3139:
URL: https://github.com/apache/bookkeeper/pull/3139


   ---
   
   *Motivation*
   
   When there has a bookie is slow to respond the add entry request,
   and the AQ is smaller than WQ, the client will hole the entry buffer
   and that will cause the memory won't be released.
   
   More context:
   https://github.com/apache/pulsar/issues/14861
   
   *Modifications*
   
   Add the memory limit for the client to the send add request.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] zymap commented on pull request #3139: [WIP] Add memory limiter for the add entry request to avoid OOM

Posted by GitBox <gi...@apache.org>.

zymap commented on pull request #3139:
URL: https://github.com/apache/bookkeeper/pull/3139#issuecomment-1080580268


   @dlg99 Thanks for your information. But looks like the maxAddsInProgressLimit only applied on the v3 request? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] dlg99 commented on pull request #3139: [WIP] Add memory limiter for the add entry request to avoid OOM

Posted by GitBox <gi...@apache.org>.

dlg99 commented on pull request #3139:
URL: https://github.com/apache/bookkeeper/pull/3139#issuecomment-1080214001


   @zymap Have you tried [configuring backpressure](https://lists.apache.org/thread/0kdpo6g6scd47y0mzpd35ovr3003zt5c) for the BK client and server? I think it covers your case. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org