You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/06/20 20:09:55 UTC
[GitHub] [arrow-datafusion] alamb opened a new issue, #6733: Implement serialization for UDWF as window function in plan protobuf #4584
alamb opened a new issue, #6733:
URL: https://github.com/apache/arrow-datafusion/issues/6733
### Is your feature request related to a problem or challenge?
Similarly to https://github.com/apache/arrow-datafusion/issues/4584
Follow on to https://github.com/apache/arrow-datafusion/pull/6703 to add serialization support for user defined window functions when serializing plans
### Describe the solution you'd like
_No response_
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement serialization for UDWF as window function in plan protobuf #4584 [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #6733: Implement serialization for UDWF as window function in plan protobuf #4584
URL: https://github.com/apache/arrow-datafusion/issues/6733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement serialization for UDWF as window function in plan protobuf #4584 [arrow-datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on issue #6733:
URL: https://github.com/apache/arrow-datafusion/issues/6733#issuecomment-1785059290
This issue looks good to close?
cc @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] parkma99 commented on issue #6733: Implement serialization for UDWF as window function in plan protobuf #4584
Posted by "parkma99 (via GitHub)" <gi...@apache.org>.
parkma99 commented on issue #6733:
URL: https://github.com/apache/arrow-datafusion/issues/6733#issuecomment-1603999457
I would like to work this.Could you give me some tips for starting this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement serialization for UDWF as window function in plan protobuf #4584 [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6733:
URL: https://github.com/apache/arrow-datafusion/issues/6733#issuecomment-1785692649
I agree -- thanks @Jefffrey (and @parkma99 !)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #6733: Implement serialization for UDWF as window function in plan protobuf #4584
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6733:
URL: https://github.com/apache/arrow-datafusion/issues/6733#issuecomment-1605364859
The basic idea would be to fix this code: https://github.com/apache/arrow-datafusion/blob/80d1750fda0f8d1d09d7bbf5b05662b1f6618954/datafusion/proto/src/logical_plan/to_proto.rs#L593-L597
I think you can generally follow the model of `AggregateUDF`
So I would recommend this order:
1. Write a round trip test first -- following the model of https://github.com/apache/arrow-datafusion/blob/80d1750fda0f8d1d09d7bbf5b05662b1f6618954/datafusion/proto/src/logical_plan/mod.rs#L2606-L2663
2. Write the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] parkma99 commented on issue #6733: Implement serialization for UDWF as window function in plan protobuf #4584
Posted by "parkma99 (via GitHub)" <gi...@apache.org>.
parkma99 commented on issue #6733:
URL: https://github.com/apache/arrow-datafusion/issues/6733#issuecomment-1605829769
> I think you can generally follow the model of AggregateUDF
@alamb Thanks, I will have a look late.😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org