You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/01/21 13:38:11 UTC
Review Request 30117: |Storm cluster metrics need to be reported to
AMS
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30117/
-----------------------------------------------------------
Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
Bugs: AMBARI-9233
https://issues.apache.org/jira/browse/AMBARI-9233
Repository: ambari
Description
-------
Current implementation of the Storm Sink reports topology metrics to the AMS but not cluster metrics
Ambari web UI needs the cluster level metrics.
Need a implementation of Reporter similar to Ganglia to push cluster metrics.
Diffs
-----
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java a382ccb
ambari-metrics/ambari-metrics-storm-sink/src/main/assemblies/jar-with-common.xml e6d9f0b
ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2 6d333d5
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java PRE-CREATION
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java 1fd81de
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params.py 952a386
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 1a7a754
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/config.yaml.j2 445df31
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/storm-metrics2.properties.j2 6d333d5
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/storm.yaml.j2 e6eed41
ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/storm-env.xml b9f1927
Diff: https://reviews.apache.org/r/30117/diff/
Testing
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [3.382s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.377s]
[INFO] Ambari Web ........................................ SUCCESS [37.411s]
[INFO] Ambari Views ...................................... SUCCESS [2.433s]
[INFO] Ambari Admin View ................................. SUCCESS [10.626s]
[INFO] Ambari Server ..................................... SUCCESS [42:04.338s]
[INFO] Ambari Agent ...................................... SUCCESS [7.702s]
[INFO] Ambari Client ..................................... SUCCESS [0.046s]
[INFO] Ambari Python Client .............................. SUCCESS [0.692s]
[INFO] Ambari Groovy Client .............................. SUCCESS [12.088s]
[INFO] Ambari Shell ...................................... SUCCESS [0.037s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.072s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [10.078s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
Thanks,
Dmytro Sen
Re: Review Request 30117: |Storm cluster metrics need to be reported
to AMS
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30117/#review71351
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Jan. 21, 2015, 12:38 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30117/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2015, 12:38 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-9233
> https://issues.apache.org/jira/browse/AMBARI-9233
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Current implementation of the Storm Sink reports topology metrics to the AMS but not cluster metrics
> Ambari web UI needs the cluster level metrics.
> Need a implementation of Reporter similar to Ganglia to push cluster metrics.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java a382ccb
> ambari-metrics/ambari-metrics-storm-sink/src/main/assemblies/jar-with-common.xml e6d9f0b
> ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2 6d333d5
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java PRE-CREATION
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java 1fd81de
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params.py 952a386
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 1a7a754
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/config.yaml.j2 445df31
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/storm-metrics2.properties.j2 6d333d5
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/storm.yaml.j2 e6eed41
> ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/storm-env.xml b9f1927
>
> Diff: https://reviews.apache.org/r/30117/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [3.382s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.377s]
> [INFO] Ambari Web ........................................ SUCCESS [37.411s]
> [INFO] Ambari Views ...................................... SUCCESS [2.433s]
> [INFO] Ambari Admin View ................................. SUCCESS [10.626s]
> [INFO] Ambari Server ..................................... SUCCESS [42:04.338s]
> [INFO] Ambari Agent ...................................... SUCCESS [7.702s]
> [INFO] Ambari Client ..................................... SUCCESS [0.046s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.692s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [12.088s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.037s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.072s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [10.078s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> Dmytro Sen
>
>