[jira] [Comment Edited] (FINERACT-1157) UnsupportedOperationException at InteropServiceImpl

["Michael Vorburger (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FINERACT-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201134#comment-17201134 ] 

Michael Vorburger edited comment on FINERACT-1157 at 9/23/20, 10:13 PM:
------------------------------------------------------------------------

https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/interoperation/service/InteropServiceImpl.java is full of {{throw new UnsupportedOperationException()}} for what all appear to be conditions that should be progagated to the REST API, that seems wrong error handling; so this should be fixed in general, not just in line 179 (above).


was (Author: vorburger):
https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/interoperation/service/InteropServiceImpl.java is full of throw new UnsupportedOperationException() for what appear to be conditions that should be progagated to the REST API, so this should be fixed in general, not just in line 179 (above).

> UnsupportedOperationException at InteropServiceImpl
> ---------------------------------------------------
>
>                 Key: FINERACT-1157
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1157
>             Project: Apache Fineract
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Michael Vorburger
>            Priority: Blocker
>              Labels: beginner
>             Fix For: 1.5.0
>
>
> See FINERACT-932 for general background, and fix this problem by making it return an appropriate HTTP 4xx client validation error instead of an internal server UnsupportedOperationException:
> {code} java.lang.UnsupportedOperationException: Account not found for identifier ACCOUNT_ID/000000013
>         at org.apache.fineract.interoperation.service.InteropServiceImpl.getAccountByIdentifier (InteropServiceImpl.java:179)
>         at org.apache.fineract.interoperation.service.InteropServiceImpl$$FastClassBySpringCGLIB$$275e2ef6.invoke (<generated>) {code}
> [~edcable] do you know who may be interested in fixing bugs in InterOp?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)