You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/04 07:32:32 UTC

[GitHub] [airflow] makrushin-evgenii commented on pull request #21297: Add another way to dynamically generate DAGs to docs

makrushin-evgenii commented on pull request #21297:
URL: https://github.com/apache/airflow/pull/21297#issuecomment-1029725180


   > Hi @makrushin-evgenii
   > 
   > I like this example. Taking a look at this, it seems this section on "dynamic dag generation" is getting rather long and starting to look like more of a "how to" than a "best practices".
   > 
   > I think it might be best if we create a "how to" page called "dynamic dag generation" or perhaps "Config-based dag generation". Then in the "best practices" page we can keep a more succinct message about what really is the "best practice" we're trying to emphasize in this area, and we can link to the how-to ("for more details on dag generation, see our how-to...").
   > 
   > Would you be interested in takking this on as part of this PR?
   
   You're right. Want to do it this way, but forgot about the "How To" page. I'll make changes in a few days
   
   A few clarifications:
   1. Should I move all "dynamic dag generation" section content from "best practies" page to "how to", or just mine? If just mine, should I copy all "dynamic dag generation" section content to "how to"?
   2. Can I use a links to external resources, e.g. [Astronomer guide "Dynamically Generating DAGs in Airflow"](https://www.astronomer.io/guides/dynamically-generating-dags)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org