You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2017/02/09 19:44:11 UTC
Review Request 56514: GEODE-2455: change test to use AssertJ
assertThatThrownBy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56514/
-----------------------------------------------------------
Review request for geode, Jinmei Liao, Jared Stewart, and Kevin Duling.
Bugs: GEODE-2455
https://issues.apache.org/jira/browse/GEODE-2455
Repository: geode
Description
-------
GEODE-2455: change test to use AssertJ assertThatThrownBy
Diffs
-----
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/DescribeDiskStoreFunctionJUnitTest.java 469fab8
Diff: https://reviews.apache.org/r/56514/diff/
Testing
-------
DescribeDiskStoreFunctionJUnitTest
Thanks,
Kirk Lund
Re: Review Request 56514: GEODE-2455: change test to use AssertJ
assertThatThrownBy
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56514/#review165004
-----------------------------------------------------------
Ship it!
Ship It!
- Jared Stewart
On Feb. 9, 2017, 7:46 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56514/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 7:46 p.m.)
>
>
> Review request for geode, Jinmei Liao, Jared Stewart, and Kevin Duling.
>
>
> Bugs: GEODE-2455
> https://issues.apache.org/jira/browse/GEODE-2455
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2455: change test to use AssertJ assertThatThrownBy
>
> enter random text to allow review board publish to work
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/DescribeDiskStoreFunctionJUnitTest.java 469fab8
>
> Diff: https://reviews.apache.org/r/56514/diff/
>
>
> Testing
> -------
>
> DescribeDiskStoreFunctionJUnitTest
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 56514: GEODE-2455: change test to use AssertJ
assertThatThrownBy
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56514/
-----------------------------------------------------------
(Updated Feb. 9, 2017, 7:46 p.m.)
Review request for geode, Jinmei Liao, Jared Stewart, and Kevin Duling.
Bugs: GEODE-2455
https://issues.apache.org/jira/browse/GEODE-2455
Repository: geode
Description (updated)
-------
GEODE-2455: change test to use AssertJ assertThatThrownBy
enter random text to allow review board publish to work
Diffs
-----
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/DescribeDiskStoreFunctionJUnitTest.java 469fab8
Diff: https://reviews.apache.org/r/56514/diff/
Testing
-------
DescribeDiskStoreFunctionJUnitTest
Thanks,
Kirk Lund
Re: Review Request 56514: GEODE-2455: change test to use AssertJ
assertThatThrownBy
Posted by Kevin Duling <kd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56514/#review164996
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Duling
On Feb. 9, 2017, 11:44 a.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56514/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 11:44 a.m.)
>
>
> Review request for geode, Jinmei Liao, Jared Stewart, and Kevin Duling.
>
>
> Bugs: GEODE-2455
> https://issues.apache.org/jira/browse/GEODE-2455
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2455: change test to use AssertJ assertThatThrownBy
>
> enter random text to allow review board publish to work
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/DescribeDiskStoreFunctionJUnitTest.java 469fab8
>
> Diff: https://reviews.apache.org/r/56514/diff/
>
>
> Testing
> -------
>
> DescribeDiskStoreFunctionJUnitTest
>
>
> Thanks,
>
> Kirk Lund
>
>