You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "jsai28 (via GitHub)" <gi...@apache.org> on 2025/03/17 18:41:14 UTC
[I] Migrate the following tests to `insta` [datafusion]
jsai28 opened a new issue, #15282:
URL: https://github.com/apache/datafusion/issues/15282
In #15178, @blaginin outlined a few areas where insta snapshots should replace the use of pre-defined strings. There's a few other files where snapshot tests need to be added that are not included in the original epic. Here are files that still use pre-defined strings for comparison tests:
- `datafusion/common/src/scalar/mod.rs`
- `datafusion/core/src/execution/context/csv.rs`
- `datafusion/core/src/execution/context/mod.rs`
- `datafusion/core/tests/catalog/memory.rs`
- `datafusion/core/tests/parquet/custom_reader.rs`
- `datafusion/core/tests/parquet/schema_coercion.rs`
- `datafusion/core/tests/parquet/schema.rs`
- `datafusion/core/tests/sql/aggregates.rs`
- `datafusion/core/tests/sql/path_partition.rs`
- `datafusion/core/tests/sql/select.rs`
- `datafusion-cli/src/main.rs`
- `datafusion/physical-optimizer/src/pruning.rs`
Most of these files contain 1-3 tests that need to be updated so I don't think it needs to be split into further pieces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Migrate the following tests to `insta` [datafusion]
Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on issue #15282:
URL: https://github.com/apache/datafusion/issues/15282#issuecomment-2730556871
Thanks, added to the list 🌻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Migrate the following tests to `insta` [datafusion]
Posted by "xudong963 (via GitHub)" <gi...@apache.org>.
xudong963 closed issue #15282: Migrate the following tests to `insta`
URL: https://github.com/apache/datafusion/issues/15282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Migrate the following tests to `insta` [datafusion]
Posted by "jsai28 (via GitHub)" <gi...@apache.org>.
jsai28 commented on issue #15282:
URL: https://github.com/apache/datafusion/issues/15282#issuecomment-2730914857
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org