[GitHub] [lucene-solr] ctargett commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component

[GitBox <gi...@apache.org>]

ctargett commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component
URL: https://github.com/apache/lucene-solr/pull/1292#issuecomment-595237017
 
 
   The changes here are slightly confusing because the descriptions of the Jira and the PR refer to documenting `add-expressible` (and etc.), but there are examples added for `delete-requesthandler`, which is tangential & sort of thrown in there. While the title of this PR mentions it, the descriptions don't so it's hard to know what to expect...it's fine in the end, it's just a barrier to a review to note for future PRs.
   
   I left another specific comment on the new page, and generally that content is good. However, I know it will fail the build because there is no edit to a page to include the new page as a child of another (so it does not currently fit anywhere in the page hierarchy), which means you didn't run the build first and there could be other issues that need to be resolved before this can be committed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org