You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2010/11/01 01:29:24 UTC
[jira] Commented: (WICKET-3139) Fix comments for Form.process() to
be consistent with method declaration
[ https://issues.apache.org/jira/browse/WICKET-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926801#action_12926801 ]
Hudson commented on WICKET-3139:
--------------------------------
Integrated in Apache Wicket 1.5.x #476 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/476/])
> Fix comments for Form.process() to be consistent with method declaration
> ------------------------------------------------------------------------
>
> Key: WICKET-3139
> URL: https://issues.apache.org/jira/browse/WICKET-3139
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M2.1
> Environment: All
> Reporter: Daniel Toffetti
> Assignee: Martin Grigorov
> Priority: Trivial
> Fix For: 1.5-M4
>
>
> /**
> * Process the form. Though you can override this method to provide your whole own algorithm, it
> * is not recommended to do so.
> * <p>
> * See the class documentation for further details on the form processing
> * </p>
> *
> * @return False if the form had an error
> */
> private boolean process()
> {
> The comment for Form.process() states "you can override" when in fact the method is declared private. This is most likely caused by the method being public previously. Either make it protected, or change the comment. Also compare to this other method in Form which is public and overridable:
> public void process(IFormSubmittingComponent submittingComponent)
> {
> And lastly, please provide some help in the Migration Guide for those who used to override it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.