[GitHub] ddragosd commented on a change in pull request #56: fixing the issue with container reuse for consecutive invocations

[gi...@git.apache.org]

ddragosd commented on a change in pull request #56: fixing the issue with container reuse for consecutive invocations
URL: https://github.com/apache/incubator-openwhisk-devtools/pull/56#discussion_r142480459
 
 

 ##########
 File path: docker-compose/Makefile
 ##########
 @@ -6,10 +6,18 @@ WSK_CLI ?= $(PROJECT_HOME)/bin/wsk
 
 OPEN_WHISK_DB_PREFIX ?= local_
 
+DOCKER_KERNEL ?= $(shell docker version --format "{{.Server.KernelVersion}}")
+RUNC_BINARY   ?= $(shell if [[ $(DOCKER_KERNEL) == *-moby || $(DOCKER_KERNEL) ==  *-boot2docker ]]; then (docker run --rm --privileged --pid=host debian nsenter -t 1 -m -u -n -i sh -c "which runc || which docker-runc"); else (which runc || which docker-runc); fi)
+DOCKER_BINARY ?= $(shell if [[ $(DOCKER_KERNEL) == *-moby || $(DOCKER_KERNEL) ==  *-boot2docker ]]; then (docker run --rm --privileged --pid=host debian nsenter -t 1 -m -u -n -i sh -c "which docker"); else (which docker); fi)
+
 ifndef VERBOSE
 .SILENT:
 endif
 
+.PHONY: ddd
+ddd:
+	$(shell cat ~/tmp/openwhisk/local.env) && echo $${DOCKER_IMAGE_PREFIX}
+
 
 Review comment:
   good catch ? 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services