You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/26 14:06:34 UTC

[GitHub] [flink] aljoscha commented on a change in pull request #13775: [FLINK-19479][DataStream] Allow explicitly configuring time behaviour on KeyedStream.intervalJoin()

aljoscha commented on a change in pull request #13775:
URL: https://github.com/apache/flink/pull/13775#discussion_r511985631



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
##########
@@ -454,11 +479,7 @@ private static boolean isEnumType(TypeInformation<?> type) {
 		 */
 		@PublicEvolving
 		public IntervalJoined<T1, T2, KEY> between(Time lowerBound, Time upperBound) {
-
-			TimeCharacteristic timeCharacteristic =
-				streamOne.getExecutionEnvironment().getStreamTimeCharacteristic();
-
-			if (timeCharacteristic != TimeCharacteristic.EventTime) {
+			if (timeBehaviour != TimeBehaviour.EventTime) {

Review comment:
       It's interesting, we allow users to call `inProcessingTime()` but it will not work because of this. 😅 Maybe we should just document that an interval join is always in event time and don't allow configuring it for now?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org