You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by GitBox <gi...@apache.org> on 2021/08/31 13:34:05 UTC
[GitHub] [tomee-patch-plugin] t-gergely opened a new pull request #4: sourceExcludes didn't work on Windows
t-gergely opened a new pull request #4:
URL: https://github.com/apache/tomee-patch-plugin/pull/4
Building tomee-webprofile-webapp-9.0.0-M7 was not possible on Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee-patch-plugin] rzo1 commented on pull request #4: sourceExcludes didn't work on Windows
Posted by GitBox <gi...@apache.org>.
rzo1 commented on pull request #4:
URL: https://github.com/apache/tomee-patch-plugin/pull/4#issuecomment-909380261
Thanks for the additonal information. I tested it on my Linux and Windows system. LGTM. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee-patch-plugin] rzo1 merged pull request #4: sourceExcludes didn't work on Windows
Posted by GitBox <gi...@apache.org>.
rzo1 merged pull request #4:
URL: https://github.com/apache/tomee-patch-plugin/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee-patch-plugin] rzo1 commented on pull request #4: sourceExcludes didn't work on Windows
Posted by GitBox <gi...@apache.org>.
rzo1 commented on pull request #4:
URL: https://github.com/apache/tomee-patch-plugin/pull/4#issuecomment-909317548
Thanks for the PR and the contribution @t-gergely !
Did you try building it with version `0.6` of the patch plugin on Windows or just the bundled source from the download page? Did the plugin throw some exceptions?
I am asking because we fixed some Windows specific flaws in #3 and released them in `0.6` and I want to reproduce the behaviour on my Windows machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee-patch-plugin] rzo1 merged pull request #4: sourceExcludes didn't work on Windows
Posted by GitBox <gi...@apache.org>.
rzo1 merged pull request #4:
URL: https://github.com/apache/tomee-patch-plugin/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee-patch-plugin] rzo1 commented on pull request #4: sourceExcludes didn't work on Windows
Posted by GitBox <gi...@apache.org>.
rzo1 commented on pull request #4:
URL: https://github.com/apache/tomee-patch-plugin/pull/4#issuecomment-909317548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee-patch-plugin] t-gergely commented on pull request #4: sourceExcludes didn't work on Windows
Posted by GitBox <gi...@apache.org>.
t-gergely commented on pull request #4:
URL: https://github.com/apache/tomee-patch-plugin/pull/4#issuecomment-909337331
> Did you try building it with version `0.6` of the patch plugin on Windows or just the bundled source from the download page?
First, the 0.5 version that was specified in the pom of tomee-jakarta.git/tag tomee-project-9.0.0-M7. Then master/0.6-SNAPSHOT from this repo.
> Did the plugin throw some exceptions?
tomee-jakarta/tomee/tomee-webprofile-webapp/pom.xml has
```
<sourceExcludes>
<exclude>org/apache/cxf/jaxb</exclude>
</sourceExcludes>
```
It didn't work, so the plugin failed compilation with jaxb related "cannot find symbol" errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee-patch-plugin] t-gergely commented on pull request #4: sourceExcludes didn't work on Windows
Posted by GitBox <gi...@apache.org>.
t-gergely commented on pull request #4:
URL: https://github.com/apache/tomee-patch-plugin/pull/4#issuecomment-909337331
> Did you try building it with version `0.6` of the patch plugin on Windows or just the bundled source from the download page?
First, the 0.5 version that was specified in the pom of tomee-jakarta.git/tag tomee-project-9.0.0-M7. Then master/0.6-SNAPSHOT from this repo.
> Did the plugin throw some exceptions?
tomee-jakarta/tomee/tomee-webprofile-webapp/pom.xml has
```
<sourceExcludes>
<exclude>org/apache/cxf/jaxb</exclude>
</sourceExcludes>
```
It didn't work, so the plugin failed compilation with jaxb related "cannot find symbol" errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org