You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/09 09:50:44 UTC
[GitHub] [rocketmq-client-go] Me1onRind opened a new pull request #383: add
retry topic callback and abstract a function
Me1onRind opened a new pull request #383: add retry topic callback and abstract a function
URL: https://github.com/apache/rocketmq-client-go/pull/383
#382
add retry topic callback function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io commented on issue #383: add retry
topic callback and abstract a function
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #383: add retry topic callback and abstract a function
URL: https://github.com/apache/rocketmq-client-go/pull/383#issuecomment-572489453
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/383?src=pr&el=h1) Report
> Merging [#383](https://codecov.io/gh/apache/rocketmq-client-go/pull/383?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/145a42c148954d9464f13399dc8203367a88b27f?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `90%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/383/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/383?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #383 +/- ##
==========================================
+ Coverage 25.37% 25.41% +0.03%
==========================================
Files 47 47
Lines 5470 5470
==========================================
+ Hits 1388 1390 +2
+ Misses 3892 3890 -2
Partials 190 190
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/383?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/383/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `13.69% <90%> (+0.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/383?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/383?src=pr&el=footer). Last update [145a42c...9a549f0](https://codecov.io/gh/apache/rocketmq-client-go/pull/383?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io edited a comment on issue #383: add
retry topic callback and abstract a function
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #383: add retry topic callback and abstract a function
URL: https://github.com/apache/rocketmq-client-go/pull/383#issuecomment-572489453
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/383?src=pr&el=h1) Report
> Merging [#383](https://codecov.io/gh/apache/rocketmq-client-go/pull/383?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/145a42c148954d9464f13399dc8203367a88b27f?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `90%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/383/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/383?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #383 +/- ##
==========================================
+ Coverage 25.37% 25.41% +0.03%
==========================================
Files 47 47
Lines 5470 5470
==========================================
+ Hits 1388 1390 +2
+ Misses 3892 3890 -2
Partials 190 190
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/383?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/383/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `13.69% <90%> (+0.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/383?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/383?src=pr&el=footer). Last update [145a42c...9a549f0](https://codecov.io/gh/apache/rocketmq-client-go/pull/383?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing commented on issue #383: add retry
topic callback and abstract a function
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on issue #383: add retry topic callback and abstract a function
URL: https://github.com/apache/rocketmq-client-go/pull/383#issuecomment-572543905
discussed in ISSUE #382
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services