You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@apache.org on 2002/05/06 16:02:50 UTC

cvs commit: httpd-2.0/modules/mappers mod_rewrite.c

trawick     02/05/06 07:02:50

  Modified:    modules/mappers mod_rewrite.c
  Log:
  fix the type of the pointer returned by the hash lookup
  
  Revision  Changes    Path
  1.109     +2 -1      httpd-2.0/modules/mappers/mod_rewrite.c
  
  Index: mod_rewrite.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/mappers/mod_rewrite.c,v
  retrieving revision 1.108
  retrieving revision 1.109
  diff -u -r1.108 -r1.109
  --- mod_rewrite.c	6 May 2002 03:10:24 -0000	1.108
  +++ mod_rewrite.c	6 May 2002 14:02:50 -0000	1.109
  @@ -462,7 +462,8 @@
           newmap->type      = MAPTYPE_INT;
           newmap->datafile  = NULL;
           newmap->checkfile = NULL;
  -        newmap->func      = apr_hash_get(mapfunc_hash, a2+4, strlen(a2+4));
  +        newmap->func      = (char *(*)(request_rec *,char *))
  +                            apr_hash_get(mapfunc_hash, a2+4, strlen(a2+4));
           if ((sconf->state == ENGINE_ENABLED) && (newmap->func == NULL)) {
               return apr_pstrcat(cmd->pool, "RewriteMap: internal map not found:",
                                 a2+4, NULL);
  
  
  

Re: cvs commit: httpd-2.0/modules/mappers mod_rewrite.c

Posted by Cliff Woolley <jw...@virginia.edu>.
On 6 May 2002, Jeff Trawick wrote:

> IBM's native compiler for AIX failed the compile
> HP's native compiler for HP-UX issued a warning

As if I couldn't have guessed.  ;)  Thanks again.

--Cliff

--------------------------------------------------------------
   Cliff Woolley
   cliffwoolley@yahoo.com
   Charlottesville, VA



Re: cvs commit: httpd-2.0/modules/mappers mod_rewrite.c

Posted by Jeff Trawick <tr...@attglobal.net>.
Cliff Woolley <jw...@virginia.edu> writes:

> On 6 May 2002 trawick@apache.org wrote:
> 
> > trawick     02/05/06 07:02:50
> >
> >   Modified:    modules/mappers mod_rewrite.c
> >   Log:
> >   fix the type of the pointer returned by the hash lookup
> 
> Thanks for the fix.  Just out of curiosity, which compiler choked on
> casting a (void *) as a function pointer implicitly?

IBM's native compiler for AIX failed the compile
HP's native compiler for HP-UX issued a warning

ISTR that IBM's native compiler for OS/390 and the native compiler for
Tru64 will both fail the compile with such an error

(this is with the compiler settings normally used for Apache)

-- 
Jeff Trawick | trawick@attglobal.net
Born in Roswell... married an alien...

Re: cvs commit: httpd-2.0/modules/mappers mod_rewrite.c

Posted by Cliff Woolley <jw...@virginia.edu>.
On 6 May 2002 trawick@apache.org wrote:

> trawick     02/05/06 07:02:50
>
>   Modified:    modules/mappers mod_rewrite.c
>   Log:
>   fix the type of the pointer returned by the hash lookup

Thanks for the fix.  Just out of curiosity, which compiler choked on
casting a (void *) as a function pointer implicitly?  I didn't know there
was a problem with that.

--Cliff

--------------------------------------------------------------
   Cliff Woolley
   cliffwoolley@yahoo.com
   Charlottesville, VA