[GitHub] [calcite] xy2953396112 commented on a change in pull request #2373: [CALCITE-3338] Error with executeBatch and preparedStatement when usi…

[GitBox <gi...@apache.org>]

xy2953396112 commented on a change in pull request #2373:
URL: https://github.com/apache/calcite/pull/2373#discussion_r600315859



##########
File path: core/src/test/java/org/apache/calcite/jdbc/CalciteRemoteDriverTest.java
##########
@@ -880,6 +880,40 @@ public Service create(AvaticaConnection connection) {
     assertThat(updateCount, is(1));
   }
 
+  @Test public void testInsertBatchWithPreparedStatement() throws Exception {
+    final Connection connection = DriverManager.getConnection(
+        "jdbc:avatica:remote:factory="
+            + LocalServiceModifiableFactory.class.getName());
+    assertThat(connection.getMetaData().supportsBatchUpdates(), is(true));
+    assertThat(connection.isClosed(), is(false));

Review comment:
       To check that the `connection` is correct.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org