You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/08/04 02:48:05 UTC

[kudu-CR] KUDU-2671 range-specific hash schemas for 'kudu table add range partition'

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18814


Change subject: KUDU-2671 range-specific hash schemas for 'kudu table add_range_partition'
......................................................................

KUDU-2671 range-specific hash schemas for 'kudu table add_range_partition'

This patch adds support for range-specific hash schemas into the
'kudu table add_range_partition' CLI tool.  This patch also contains
a test scenario to cover the newly introduced functionality.

An example of usage:

  kudu table add_range_partition $KUDU_MASTER my_table [0] [1] --range_hash_schema='{"hash_schema": [{"columns": ["key"], "num_buckets": 5, "seed": 8}]}'

Change-Id: I3832312b6ebfb397bb3083931f6d53039afc5e9b
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_table.cc
3 files changed, 210 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/18814/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3832312b6ebfb397bb3083931f6d53039afc5e9b
Gerrit-Change-Number: 18814
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] KUDU-2671 range-specific hash schemas for 'kudu table add range partition'

Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18814 )

Change subject: KUDU-2671 range-specific hash schemas for 'kudu table add_range_partition'
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3832312b6ebfb397bb3083931f6d53039afc5e9b
Gerrit-Change-Number: 18814
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 04 Aug 2022 18:16:29 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2671 range-specific hash schemas for 'kudu table add range partition'

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Tidy Bot, Yingchun Lai, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18814

to look at the new patch set (#2).

Change subject: KUDU-2671 range-specific hash schemas for 'kudu table add_range_partition'
......................................................................

KUDU-2671 range-specific hash schemas for 'kudu table add_range_partition'

This patch adds support for range-specific hash schemas into the
'kudu table add_range_partition' CLI tool.  This patch also contains
a test scenario to cover the newly introduced functionality.

An example of usage:

  kudu table add_range_partition $KUDU_MASTER my_table [0] [1] \
    --hash_schema='{"hash_schema": [{"columns": ["c"], "num_buckets": 5}]}'

Change-Id: I3832312b6ebfb397bb3083931f6d53039afc5e9b
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_table.cc
3 files changed, 210 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/18814/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3832312b6ebfb397bb3083931f6d53039afc5e9b
Gerrit-Change-Number: 18814
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] KUDU-2671 range-specific hash schemas for 'kudu table add range partition'

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18814 )

Change subject: KUDU-2671 range-specific hash schemas for 'kudu table add_range_partition'
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/18814/1/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:

http://gerrit.cloudera.org:8080/#/c/18814/1/src/kudu/tools/tool_action_table.cc@156
PS1, Line 156: JSON "
> Would it be valuable to add an example?
That's a good point!  Done.


http://gerrit.cloudera.org:8080/#/c/18814/1/src/kudu/tools/tool_action_table.cc@1031
PS1, Line 1031:     if (hash_schema_str.empty()) {
> warning: 4th function call argument is an uninitialized value [clang-analyz
That's a bogus warning: the argument is initialized at line 1013


http://gerrit.cloudera.org:8080/#/c/18814/1/src/kudu/tools/tool_action_table.cc@1031
PS1, Line 1031:     if (hash_schema_str.empty()) {
> warning: 3rd function call argument is an uninitialized value [clang-analyz
That's a bogus warning: the argument is initialized at line 1009



-- 
To view, visit http://gerrit.cloudera.org:8080/18814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3832312b6ebfb397bb3083931f6d53039afc5e9b
Gerrit-Change-Number: 18814
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 04 Aug 2022 17:38:41 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2671 range-specific hash schemas for 'kudu table add range partition'

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: KUDU-2671 range-specific hash schemas for 'kudu table add_range_partition'
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3832312b6ebfb397bb3083931f6d53039afc5e9b
Gerrit-Change-Number: 18814
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] KUDU-2671 range-specific hash schemas for 'kudu table add range partition'

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18814 )

Change subject: KUDU-2671 range-specific hash schemas for 'kudu table add_range_partition'
......................................................................


Patch Set 2: Verified+1

unrelated test failure (DEBUG):

  LocationAwareRebalancingParamTest.RebalanceWithIgnoredTServer/idx4_rf3_t3_l_3_2_1


-- 
To view, visit http://gerrit.cloudera.org:8080/18814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3832312b6ebfb397bb3083931f6d53039afc5e9b
Gerrit-Change-Number: 18814
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 04 Aug 2022 18:20:37 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2671 range-specific hash schemas for 'kudu table add range partition'

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18814 )

Change subject: KUDU-2671 range-specific hash schemas for 'kudu table add_range_partition'
......................................................................

KUDU-2671 range-specific hash schemas for 'kudu table add_range_partition'

This patch adds support for range-specific hash schemas into the
'kudu table add_range_partition' CLI tool.  This patch also contains
a test scenario to cover the newly introduced functionality.

An example of usage:

  kudu table add_range_partition $KUDU_MASTER my_table [0] [1] \
    --hash_schema='{"hash_schema": [{"columns": ["c"], "num_buckets": 5}]}'

Change-Id: I3832312b6ebfb397bb3083931f6d53039afc5e9b
Reviewed-on: http://gerrit.cloudera.org:8080/18814
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_table.cc
3 files changed, 210 insertions(+), 9 deletions(-)

Approvals:
  Abhishek Chennaka: Looks good to me, but someone else must approve
  Mahesh Reddy: Looks good to me, but someone else must approve
  Alexey Serbin: Verified
  Attila Bukor: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3832312b6ebfb397bb3083931f6d53039afc5e9b
Gerrit-Change-Number: 18814
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] KUDU-2671 range-specific hash schemas for 'kudu table add range partition'

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18814 )

Change subject: KUDU-2671 range-specific hash schemas for 'kudu table add_range_partition'
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18814/1/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:

http://gerrit.cloudera.org:8080/#/c/18814/1/src/kudu/tools/tool_action_table.cc@156
PS1, Line 156: JSON object
Would it be valuable to add an example?



-- 
To view, visit http://gerrit.cloudera.org:8080/18814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3832312b6ebfb397bb3083931f6d53039afc5e9b
Gerrit-Change-Number: 18814
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 04 Aug 2022 10:38:36 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2671 range-specific hash schemas for 'kudu table add range partition'

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18814 )

Change subject: KUDU-2671 range-specific hash schemas for 'kudu table add_range_partition'
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3832312b6ebfb397bb3083931f6d53039afc5e9b
Gerrit-Change-Number: 18814
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 04 Aug 2022 16:56:32 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2671 range-specific hash schemas for 'kudu table add range partition'

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18814 )

Change subject: KUDU-2671 range-specific hash schemas for 'kudu table add_range_partition'
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3832312b6ebfb397bb3083931f6d53039afc5e9b
Gerrit-Change-Number: 18814
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 04 Aug 2022 19:17:06 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2671 range-specific hash schemas for 'kudu table add range partition'

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18814 )

Change subject: KUDU-2671 range-specific hash schemas for 'kudu table add_range_partition'
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18814/2/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:

http://gerrit.cloudera.org:8080/#/c/18814/2/src/kudu/tools/tool_action_table.cc@1033
PS2, Line 1033:       return alterer->AddRangePartition(lower_bound.release(),
> warning: 4th function call argument is an uninitialized value [clang-analyz
This warning is bogus: the argument is initialized at line 1013


http://gerrit.cloudera.org:8080/#/c/18814/2/src/kudu/tools/tool_action_table.cc@1033
PS2, Line 1033:       return alterer->AddRangePartition(lower_bound.release(),
> warning: 3rd function call argument is an uninitialized value [clang-analyz
This warning is bogus: the argument is initialized at line 1009



-- 
To view, visit http://gerrit.cloudera.org:8080/18814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3832312b6ebfb397bb3083931f6d53039afc5e9b
Gerrit-Change-Number: 18814
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 04 Aug 2022 18:03:32 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2671 range-specific hash schemas for 'kudu table add range partition'

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18814 )

Change subject: KUDU-2671 range-specific hash schemas for 'kudu table add_range_partition'
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3832312b6ebfb397bb3083931f6d53039afc5e9b
Gerrit-Change-Number: 18814
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 04 Aug 2022 18:11:38 +0000
Gerrit-HasComments: No