You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Violeta Georgieva <vi...@apache.org> on 2015/10/09 13:04:54 UTC

[VOTE] Release Apache Tomcat 7.0.65

The proposed Apache Tomcat 7.0.65 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.65/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1053/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_65/

The proposed 7.0.65 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.65 Stable

Regards,
Violeta

Re: [VOTE] Release Apache Tomcat 7.0.65

Posted by Emmanuel Bourg <eb...@apache.org>.
Hi,

I noticed test failures when rebuilding Tomcat 7.0.65 on Debian with
OpenJDK 7 & 8. An IllegalArgumentException "Illegal character(s) in
message header field: Cookie:" is thrown in TestNonLoginAndBasicAuthenticator,
TestSSOnonLoginAndBasicAuthenticator and TestSSOnonLoginAndDigestAuthenticator:


Testcase: testBasicLoginThenAcceptWithCookies took 0.539 sec
        Caused an ERROR
Illegal character(s) in message header field: Cookie:
java.lang.IllegalArgumentException: Illegal character(s) in message header field: Cookie:
        at sun.net.www.protocol.http.HttpURLConnection.checkMessageHeader(HttpURLConnection.java:489)
        at sun.net.www.protocol.http.HttpURLConnection.isExternalMessageHeaderAllowed(HttpURLConnection.java:459)
        at sun.net.www.protocol.http.HttpURLConnection.setRequestProperty(HttpURLConnection.java:3018)
        at org.apache.catalina.startup.TomcatBaseTest.methodUrl(TomcatBaseTest.java:648)
        at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:625)
        at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:619)
        at org.apache.catalina.authenticator.TestSSOnonLoginAndBasicAuthenticator.doTestNonLogin(TestSSOnonLoginAndBasicAuthenticator.java:365)
        at org.apache.catalina.authenticator.TestSSOnonLoginAndBasicAuthenticator.testBasicLoginThenAcceptWithCookies(TestSSOnonLoginAndBasicAuthenticator.java:215)


Could this be a locale sensitive test case?

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat 7.0.65

Posted by Martin Grigorov <mg...@apache.org>.
[ X ] Stable - go ahead and release as 7.0.65 Stable

Tested our main application. No issues found!

On Fri, Oct 9, 2015 at 1:04 PM, Violeta Georgieva <vi...@apache.org>
wrote:

> The proposed Apache Tomcat 7.0.65 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.65/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1053/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_65/
>
> The proposed 7.0.65 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.65 Stable
>
> Regards,
> Violeta
>

Re: [VOTE] Release Apache Tomcat 7.0.65

Posted by Konstantin Kolinko <kn...@gmail.com>.
2015-10-09 14:04 GMT+03:00 Violeta Georgieva <vi...@apache.org>:
> The proposed Apache Tomcat 7.0.65 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.65/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1053/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_65/
>
> The proposed 7.0.65 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 7.0.65 Stable


Unit tests OK (Java 6, 7, 8 32-bit on Windows),  smoke testing OK.

I have some concerns about change in EL escaping rules in tag
attributes in JSP that I stated in [1],
but overall I am not able to find any official example
and it looks that using escaping there is rather rare use case.


[1] https://bz.apache.org/bugzilla/show_bug.cgi?id=57136#c21

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat 7.0.65

Posted by Violeta Georgieva <mi...@gmail.com>.
2015-10-09 14:04 GMT+03:00 Violeta Georgieva <vi...@apache.org>:
>
> The proposed Apache Tomcat 7.0.65 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.65/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1053/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_65/
>
> The proposed 7.0.65 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.65 Stable

Tested Tomcat in OSGi environment - successful.
Basic performance tests - successful.

> Regards,
> Violeta

Re: [VOTE] Release Apache Tomcat 7.0.65

Posted by Rainer Jung <ra...@kippdata.de>.
Am 09.10.2015 um 13:04 schrieb Violeta Georgieva:
> The proposed Apache Tomcat 7.0.65 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.65/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1053/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_65/
>
> The proposed 7.0.65 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.65 Stable

+1 to release, thanks for RM.

Details:

- MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src completely consistent with svn tag
- builds fine
    - warnings about unchecked calls or conversions in:
      - o.a.t.dbcp
      - javax/el/ResourceBundleELResolver.java
    Both not a regression
- build result looks consistent with binaries
- no checkstyle complaints
- no Javadoc warnings
- Unit tests: no errors or failures
    - Some details of log output see below
- JMX MBean Comparison (relative 7.0.61):
    - MBean Catalina:type=ServerClassLoader,name=common
      no longer exists
    - MBean Catalina:j2eeType=WebModule attribute
      parentClassLoader now java.net.URLClassLoader@HEXADDR,
      was org.apache.catalina.loader.StandardClassLoader@HEXADDR
    - MBean Catalina:type=ProtocolHandler attribute
      compressableMimeTypes now extended by
      "text/css,text/javascript,application/javascript"
    - java.lang:type=OperatingSystem attribute
      OpenFileDescriptorCount value 56, was 57 (down by one)

Build and tests were done using Java 1.6.0_45, java.7.home was pointing
to 1.7.0_80. OS was Solaris 10 Sparc, tcnative was 1.1.33 based on APR 
1.5.1 and OpenSSL 1.0.2d.


Unit test observation (comparing with 7.0.61):

A) New SEVERE line in unit tests

     [junit] Running org.apache.catalina.comet.TestCometProcessor
...
     [junit] INFO: Starting test case [testCometConnectorStop]
...
     [junit] INFO: Starting Servlet Engine: Apache Tomcat/7.0.65
     [junit] Oct 11, 2015 12:36:20 AM org.apache.coyote.AbstractProtocol 
start
     [junit] INFO: Starting ProtocolHandler 
["http-apr-127.0.0.1-auto-2-32969"]
     [junit] Oct 11, 2015 12:36:23 AM org.apache.coyote.AbstractProtocol 
stop
     [junit] INFO: Stopping ProtocolHandler 
["http-apr-127.0.0.1-auto-2-32969"]
     [junit] Oct 11, 2015 12:36:33 AM org.apache.coyote.AbstractProtocol 
destroy
     [junit] INFO: Destroying ProtocolHandler 
["http-apr-127.0.0.1-auto-2-32969"]
     [junit] Oct 11, 2015 12:36:33 AM 
org.apache.catalina.comet.TestCometProcessor testCometConnectorStop

     [junit] SEVERE: Status:

------------^^^^^^^^
Here it was previously "INFO" and the WriterThread said "WriterThread 
exception: java.net.SocketException: Broken pipe"

     [junit] WriterThread exception: null
     [junit] ReaderThread exception: java.net.SocketTimeoutException: 
Read timed out
     [junit] Last message: [Client: END]
     [junit] Last response line: [0]
     [junit] Last comet event: [END]
     [junit] END event occurred: [true]


B) New warning, maybe incomplete implementation

10-Oct-2015 23:36:56.872 WARNING [main] 
org.apache.catalina.session.StandardSession.writeObject Cannot serialize 
session attribute nestedNonSerializable for session null

The "null" looks strange, but maybe this is due to the way the unit test 
works.


C) New warning

WARNING: Unable to destroy WebSocket thread group [WebSocketServer-ROOT] 
as [1] threads were still running when the web application was stopped. 
The thread group will be destroyed once the threads terminate.

appeared 5 times:

- bio

org.apache.tomcat.websocket.TestWsPingPongMessages [testPingPongMessages]

org.apache.tomcat.websocket.pojo.TestPojoEndpointBase [testBug54716]

- nio

org.apache.tomcat.websocket.pojo.TestPojoEndpointBase [testBug54716]

- apr

org.apache.tomcat.websocket.TestWsRemoteEndpoint [testWriterAnnotation]

org.apache.tomcat.websocket.pojo.TestPojoEndpointBase [testBug54716]



Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat 7.0.65

Posted by Felix Schumacher <fe...@internetallee.de>.
Am 09.10.2015 um 13:04 schrieb Violeta Georgieva:
> The proposed Apache Tomcat 7.0.65 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.65/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1053/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_65/
>
> The proposed 7.0.65 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 7.0.65 Stable (non-binding)
md5, sha1 and pgp keys seem to be valid.
Tests are OK on ubuntu 14.04.3 64 bit with openjdk java version "1.7.0_79".

Regards,
  Felix
>
> Regards,
> Violeta
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org