[GitHub] [tez] yingdachen commented on a change in pull request #42: TEZ-4068: Prevent new speculative attempt after task has issued canCo…

[GitBox <gi...@apache.org>]

yingdachen commented on a change in pull request #42: TEZ-4068: Prevent new speculative attempt after task has issued canCo…
URL: https://github.com/apache/tez/pull/42#discussion_r282808255
 
 

 ##########
 File path: tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/TaskImpl.java
 ##########
 @@ -1027,7 +1027,7 @@ public void transition(TaskImpl task, TaskEvent event) {
       TaskAttempt earliestUnfinishedAttempt = null;
       for (TaskAttempt ta : task.attempts.values()) {
         // find the oldest running attempt
-        if (!ta.isFinished()) {
+        if (!ta.isFinished() && task.commitAttempt == null) {
 
 Review comment:
   adding the logic here would suggest the related comment need to be updated as well, and we need an additional log (like 1034) to differentiate different cases.
   
   I would suggest moving this if to before line 1046, and process it as a standalone special case (with log and everything)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services