You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Mikhail Bautin (JIRA)" <ji...@apache.org> on 2012/10/12 00:15:03 UTC
[jira] [Created] (HBASE-6983) Metric for unencoded size of cached
blocks
Mikhail Bautin created HBASE-6983:
-------------------------------------
Summary: Metric for unencoded size of cached blocks
Key: HBASE-6983
URL: https://issues.apache.org/jira/browse/HBASE-6983
Project: HBase
Issue Type: Improvement
Reporter: Mikhail Bautin
Priority: Minor
We need to measure the amount of unencoded data in the block cache when data block encoding is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6983) Metric for unencoded size of cached
blocks
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482566#comment-13482566 ]
Phabricator commented on HBASE-6983:
------------------------------------
Kannan has accepted the revision "[jira] [HBASE-6983] [89-fb] Metric for unencoded size of cached blocks".
lgtm!
REVISION DETAIL
https://reviews.facebook.net/D5979
BRANCH
unencoded_cache_size_v11
To: Kannan, Karthik, Liyin, aaiyer, mcorgan, JIRA, mbautin
> Metric for unencoded size of cached blocks
> ------------------------------------------
>
> Key: HBASE-6983
> URL: https://issues.apache.org/jira/browse/HBASE-6983
> Project: HBase
> Issue Type: Improvement
> Reporter: Mikhail Bautin
> Priority: Minor
> Attachments: D5979.1.patch
>
>
> We need to measure the amount of unencoded data in the block cache when data block encoding is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6983) Metric for unencoded size of cached
blocks
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-6983:
-------------------------------
Attachment: D5979.2.patch
mbautin updated the revision "[jira] [HBASE-6983] [89-fb] Metric for unencoded size of cached blocks".
Reviewers: Kannan, Karthik, Liyin, aaiyer, mcorgan, JIRA
Rebasing on incremental data block encoding changes.
REVISION DETAIL
https://reviews.facebook.net/D5979
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java
src/main/java/org/apache/hadoop/hbase/io/encoding/CopyKeyDataBlockEncoder.java
src/main/java/org/apache/hadoop/hbase/io/encoding/DataBlockEncoder.java
src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java
src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlock.java
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockCache.java
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java
src/test/java/org/apache/hadoop/hbase/regionserver/EncodedSeekPerformanceTest.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java
src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java
To: Kannan, Karthik, Liyin, aaiyer, mcorgan, JIRA, mbautin
> Metric for unencoded size of cached blocks
> ------------------------------------------
>
> Key: HBASE-6983
> URL: https://issues.apache.org/jira/browse/HBASE-6983
> Project: HBase
> Issue Type: Improvement
> Reporter: Mikhail Bautin
> Priority: Minor
> Attachments: D5979.1.patch, D5979.2.patch
>
>
> We need to measure the amount of unencoded data in the block cache when data block encoding is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6983) Metric for unencoded size of cached
blocks
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-6983:
-------------------------------
Attachment: D5979.1.patch
mbautin requested code review of "[jira] [HBASE-6983] [89-fb] Metric for unencoded size of cached blocks".
Reviewers: Kannan, Karthik, Liyin, aaiyer, mcorgan, JIRA
We need to measure the amount of unencoded data in the block cache when data block encoding is enabled.
TEST PLAN
Unit tests
REVISION DETAIL
https://reviews.facebook.net/D5979
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java
src/main/java/org/apache/hadoop/hbase/io/encoding/CopyKeyDataBlockEncoder.java
src/main/java/org/apache/hadoop/hbase/io/encoding/DataBlockEncoder.java
src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java
src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlock.java
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockCache.java
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java
src/test/java/org/apache/hadoop/hbase/regionserver/EncodedSeekPerformanceTest.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java
src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java
To: JIRA
> Metric for unencoded size of cached blocks
> ------------------------------------------
>
> Key: HBASE-6983
> URL: https://issues.apache.org/jira/browse/HBASE-6983
> Project: HBase
> Issue Type: Improvement
> Reporter: Mikhail Bautin
> Priority: Minor
> Attachments: D5979.1.patch
>
>
> We need to measure the amount of unencoded data in the block cache when data block encoding is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6983) Metric for unencoded size of cached
blocks
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-6983:
-------------------------------
Attachment: D5979.3.patch
mbautin updated the revision "[jira] [HBASE-6983] [89-fb] Metric for unencoded size of cached blocks".
Reviewers: Kannan, Karthik, Liyin, aaiyer, mcorgan, JIRA
Fixing rebase conflicts in comments
REVISION DETAIL
https://reviews.facebook.net/D5979
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java
src/main/java/org/apache/hadoop/hbase/io/encoding/CopyKeyDataBlockEncoder.java
src/main/java/org/apache/hadoop/hbase/io/encoding/DataBlockEncoder.java
src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java
src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlock.java
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockCache.java
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java
src/test/java/org/apache/hadoop/hbase/regionserver/EncodedSeekPerformanceTest.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java
src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java
To: Kannan, Karthik, Liyin, aaiyer, mcorgan, JIRA, mbautin
> Metric for unencoded size of cached blocks
> ------------------------------------------
>
> Key: HBASE-6983
> URL: https://issues.apache.org/jira/browse/HBASE-6983
> Project: HBase
> Issue Type: Improvement
> Reporter: Mikhail Bautin
> Priority: Minor
> Attachments: D5979.1.patch, D5979.2.patch, D5979.3.patch
>
>
> We need to measure the amount of unencoded data in the block cache when data block encoding is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6983) Metric for unencoded size of cached
blocks
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482817#comment-13482817 ]
Phabricator commented on HBASE-6983:
------------------------------------
mbautin has closed the revision "[jira] [HBASE-6983] [89-fb] Metric for unencoded size of cached blocks".
CHANGED PRIOR TO COMMIT
https://reviews.facebook.net/D5979?vs=20355&id=20367#differential-review-toc
REVISION DETAIL
https://reviews.facebook.net/D5979
COMMIT
https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1401513
To: Kannan, Karthik, Liyin, aaiyer, mcorgan, JIRA, mbautin
> Metric for unencoded size of cached blocks
> ------------------------------------------
>
> Key: HBASE-6983
> URL: https://issues.apache.org/jira/browse/HBASE-6983
> Project: HBase
> Issue Type: Improvement
> Reporter: Mikhail Bautin
> Priority: Minor
> Attachments: D5979.1.patch, D5979.2.patch, D5979.3.patch
>
>
> We need to measure the amount of unencoded data in the block cache when data block encoding is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira