[GitHub] [dubbo-go] wenxuwan commented on a change in pull request #1154: Fix: delete a service provider when using k8s hpa

[GitBox <gi...@apache.org>]

wenxuwan commented on a change in pull request #1154:
URL: https://github.com/apache/dubbo-go/pull/1154#discussion_r613173990



##########
File path: common/url.go
##########
@@ -344,6 +344,16 @@ func (c *URL) Key() string {
 	return buildString
 }
 
+//CacheInvokerMapKey get dir cacheInvokerMap key
+func (c *URL) CacheInvokerMapKey() string {

Review comment:
       In my opinion , The function used to get key with url with many values, so why the function name is CacheInvokerMapKey? the value will be cached in the function?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org