[GitHub] [incubator-streampark] lvshaokang commented on a diff in pull request #1866: [Feature] Reference variables as placeholders in program args and Flink SQL #1781

[GitBox <gi...@apache.org>]

lvshaokang commented on code in PR #1866:
URL: https://github.com/apache/incubator-streampark/pull/1866#discussion_r998953920


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/VariableServiceImpl.java:
##########
@@ -79,4 +105,65 @@ public Variable findByVariableCode(Long teamId, String variableCode) {
     public List<Variable> findByTeamId(Long teamId) {
         return baseMapper.selectByTeamId(teamId);
     }
+
+    /**
+     * Replace placeholders with defined variable codes.
+     * @param teamId
+     * @param paramWithPlaceholders Parameters with placeholders
+     * @return
+     */
+    @Override
+    public String replacePlaceholder(Long teamId, String paramWithPlaceholders) {

Review Comment:
   Could you add unit test for this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org