[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #72: HDDS-2341. Validate tar entry path during extraction

[GitBox <gi...@apache.org>]

dineshchitlangia commented on a change in pull request #72: HDDS-2341. Validate tar entry path during extraction
URL: https://github.com/apache/hadoop-ozone/pull/72#discussion_r337838377
 
 

 ##########
 File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/TarContainerPacker.java
 ##########
 @@ -114,12 +116,11 @@
     }
   }
 
+  @SuppressFBWarnings("NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE")
 
 Review comment:
   Can we pls add minimal javadoc to explain why we are suppressing this warning? This will ensure that in future anyone changing this code path, is cautious.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org