[GitHub] [doris] yiguolei commented on a diff in pull request #19408: [minor](fe): cleanup unused SessionVariable.

["yiguolei (via GitHub)" <gi...@apache.org>]

yiguolei commented on code in PR #19408:
URL: https://github.com/apache/doris/pull/19408#discussion_r1190199163


##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -172,24 +147,19 @@ public class SessionVariable implements Serializable, Writable {
 
     public static final long DEFAULT_INSERT_VISIBLE_TIMEOUT_MS = 10_000;
 
-    public static final String ENABLE_VECTORIZED_ENGINE = "enable_vectorized_engine";

Review Comment:
   Please not clear these session variables so early. Some user is using them, although it is useless. If you remove them, user will receive error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org