You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/05 19:18:14 UTC

[GitHub] [cloudstack] JoaoJandre commented on pull request #6938: Create API to reassign volume

JoaoJandre commented on PR #6938:
URL: https://github.com/apache/cloudstack/pull/6938#issuecomment-1338008736

   > looks generally good, but it is good convention to guard log statements of info level and below if they do parameter expansion. Please do so.
   
   As there are no processes being executed only to log the data (the data is already loaded) and we do not have a convention in using is...Enabled for a simple String construction, such the ones I added, I would rather not add it and improve the code readability.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org