You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/08 15:57:35 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #4464: HTTP doc
error about SpanLayer.
wu-sheng opened a new pull request #4464: HTTP doc error about SpanLayer.
URL: https://github.com/apache/skywalking/pull/4464
Follow https://github.com/apache/skywalking-nginx-lua/pull/21.
SpanLayer deserialization wouldn't work when literal string value is `HTTP`. It must keep consistent in protobuf definition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4464: HTTP doc error
about SpanLayer.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4464: HTTP doc error about SpanLayer.
URL: https://github.com/apache/skywalking/pull/4464#issuecomment-596224905
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4464?src=pr&el=h1) Report
> Merging [#4464](https://codecov.io/gh/apache/skywalking/pull/4464?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/74b0af9d85aa66e2666e98719b0a8c255c8cd934?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4464?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4464 +/- ##
=======================================
Coverage 24.97% 24.97%
=======================================
Files 1231 1231
Lines 28504 28504
Branches 3907 3907
=======================================
Hits 7118 7118
Misses 20727 20727
Partials 659 659
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4464?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4464?src=pr&el=footer). Last update [74b0af9...05095e0](https://codecov.io/gh/apache/skywalking/pull/4464?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4464: HTTP doc error
about SpanLayer.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4464: HTTP doc error about SpanLayer.
URL: https://github.com/apache/skywalking/pull/4464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services