You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/09 00:56:46 UTC
[GitHub] [doris] yiguolei opened a new pull request, #13196: [chore](be config) remove config use_mmap_allocate_chunk
yiguolei opened a new pull request, #13196:
URL: https://github.com/apache/doris/pull/13196
# Proposed changes
Issue Number: close #xxx
## Problem summary
This config is never used online and there exist bugs if enable this config. So that I remove this config and related tests.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13196: [chore](be config) remove config use_mmap_allocate_chunk
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13196:
URL: https://github.com/apache/doris/pull/13196#issuecomment-1272485172
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13196: [chore](be config) remove config use_mmap_allocate_chunk
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13196:
URL: https://github.com/apache/doris/pull/13196#issuecomment-1272485179
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #13196: [chore](be config) remove config use_mmap_allocate_chunk
Posted by GitBox <gi...@apache.org>.
yiguolei commented on PR #13196:
URL: https://github.com/apache/doris/pull/13196#issuecomment-1272468728
> Is it necessary to remove the settings of `vm.max_map_count` in `bin/start_be.sh`?
@adonis0147 Currently, I don't know if this config if ever used. Maybe it is useful if use huge pages in the future? And we use mmap to allocate memory in vectorized engine so it maybe useful. But I am not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13196: [chore](be config) remove config use_mmap_allocate_chunk
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13196:
URL: https://github.com/apache/doris/pull/13196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #13196: [chore](be config) remove config use_mmap_allocate_chunk
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #13196:
URL: https://github.com/apache/doris/pull/13196#issuecomment-1272438098
Is it necessary to remove the settings of `vm.max_map_count` in `bin/start_be.sh`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org