You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2015/06/11 20:42:41 UTC
[GitHub] activemq-artemis pull request: ARTEMIS-19 CLI option for message-l...
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/25
ARTEMIS-19 CLI option for message-load-balancing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis master_work
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
commit b744edd5878c446878c3540f5592a0dd4bdc1804
Author: jbertram <jb...@apache.org>
Date: 2015-06-11T18:08:00Z
ARTEMIS-19 CLI option for message-load-balancing
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-19 + ARTEMIS-109
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-19 + ARTEMIS-109
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/25#issuecomment-111321276
I will merge it for now.. there's another task to make better errors.. we can do it as part of that one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-19 + ARTEMIS-109
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/25#issuecomment-111330013
@jbertram I made one small change to this at 145fc7f82c1c5513403df4af90e1e2dbe24586a0
the CLI framework can handle the conversion already.
Going beyond this we need to treat exception per https://issues.apache.org/jira/browse/ARTEMIS-116
Also, whenever you have a chance please close these JIRAs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-19 CLI option for message-l...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the pull request:
https://github.com/apache/activemq-artemis/pull/25#issuecomment-111272599
I added some validation, but it's not very graceful. If the user enters in the wrong value it will throw an IllegalArgumentException and the create command will terminate. Obviously I can change this, but I'd like feed-back on how.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---