[GitHub] [incubator-druid] jon-wei commented on issue #8085: fix forking task runner task shutdown to be more graceful

[GitBox <gi...@apache.org>]

jon-wei commented on issue #8085: fix forking task runner task shutdown to be more graceful
URL: https://github.com/apache/incubator-druid/pull/8085#issuecomment-511597241
 
 
   > I am unable to definitively determine if this means the task is not waiting for lifecycle stop to complete, or if it's strictly a logging issue, as I have collected conflicting observations.
   
   I did a test on HadoopindexTask where I put the following code into `stopGracefully`, and killed a task (without this PR applied):
   
   ```
       try {
         FileOutputStream outputStream = new FileOutputStream("/tmp/hadoop_test_indicator");
         byte[] strToBytes = StringUtils.toUtf8("HELLO WORLD\n");
         outputStream.write(strToBytes);
         outputStream.close();
       }
       catch (Exception e) {
         log.error(e, "a");
       }
   ```
   
   The file did get written, so this does seem to be a logging-only issue.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org