You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/03 22:01:52 UTC

[GitHub] [spark] grundprinzip commented on pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL

grundprinzip commented on PR #38475:
URL: https://github.com/apache/spark/pull/38475#issuecomment-1302724487

   @amaliujia quick question, looking at the code in Dataset, why do we actually need to implement this on the server? The renaming could in theory be rewritten into a select with aliases, this would not require any server side changes and would be more true to the intent.
   
   @cloud-fan @hvanhovell what do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org