You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by pengcheng xiong <px...@hortonworks.com> on 2014/10/01 01:48:47 UTC

Review Request 26209: CBO trunk merge: union11 test fails due to incorrect plan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26209/
-----------------------------------------------------------

Review request for hive.


Repository: hive-git


Description
-------

create a derived table with new proj and aggr to address it


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/DerivedTableInjector.java a655174 
  ql/src/test/queries/clientpositive/cbo_correctness.q f7f0722 
  ql/src/test/results/clientpositive/cbo_correctness.q.out 3335d4d 

Diff: https://reviews.apache.org/r/26209/diff/


Testing
-------


Thanks,

pengcheng xiong

Re: Review Request 26209: CBO trunk merge: union11 test fails due to incorrect plan

Posted by Sergey Shelukhin <se...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26209/#review55715
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java
<https://reviews.apache.org/r/26209/#comment96101>

    whitespace; also elsewhere



ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java
<https://reviews.apache.org/r/26209/#comment96102>

    nit - can just be one line



ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java
<https://reviews.apache.org/r/26209/#comment96103>

    I think parent is always a projection, so it's SingleRel and there's only one input. Type can be made more specific all the way from introduceDerivedTable to here


- Sergey Shelukhin


On Oct. 6, 2014, 5:39 p.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26209/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2014, 5:39 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> create a derived table with new proj and aggr to address it
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 3d90ae7 
>   ql/src/test/queries/clientpositive/cbo_correctness.q f7f0722 
>   ql/src/test/results/clientpositive/cbo_correctness.q.out 3335d4d 
>   ql/src/test/results/clientpositive/tez/cbo_correctness.q.out 5920612 
> 
> Diff: https://reviews.apache.org/r/26209/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>

Re: Review Request 26209: CBO trunk merge: union11 test fails due to incorrect plan

Posted by John Pullokkaran <jp...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26209/#review55747
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java
<https://reviews.apache.org/r/26209/#comment96137>

    Instead of double negation check for isEmptyGrpAggr
    
    Return true if its empty


- John Pullokkaran


On Oct. 8, 2014, 12:09 a.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26209/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 12:09 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> create a derived table with new proj and aggr to address it
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 3d90ae7 
>   ql/src/test/queries/clientpositive/cbo_correctness.q f7f0722 
>   ql/src/test/results/clientpositive/cbo_correctness.q.out 3335d4d 
>   ql/src/test/results/clientpositive/tez/cbo_correctness.q.out 5920612 
> 
> Diff: https://reviews.apache.org/r/26209/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>