You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2015/11/24 17:54:46 UTC
Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a
test file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40654/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
Cleaned up usage of `CreateSlaveFlags()` in a test file.
Diffs
-----
src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95
Diff: https://reviews.apache.org/r/40654/diff/
Testing
-------
make check
Thanks,
Neil Conway
Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in
a test file.
Posted by Neil Conway <ne...@gmail.com>.
> On Nov. 25, 2015, 2:25 a.m., Guangya Liu wrote:
> > src/tests/authentication_tests.cpp, line 311
> > <https://reviews.apache.org/r/40654/diff/1/?file=1138954#file1138954line311>
> >
> > Not yours but do you mind to update s/Try<PID<Slave> >/Try<PID<Slave>> and the following?
Sure -- although I believe that committers would like to see these kinds of cleanups as a separate commit.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40654/#review107899
-----------------------------------------------------------
On Nov. 24, 2015, 4:54 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40654/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 4:54 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up usage of `CreateSlaveFlags()` in a test file.
>
>
> Diffs
> -----
>
> src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95
>
> Diff: https://reviews.apache.org/r/40654/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in
a test file.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40654/#review107899
-----------------------------------------------------------
src/tests/authentication_tests.cpp (line 311)
<https://reviews.apache.org/r/40654/#comment167224>
Not yours but do you mind to update s/Try<PID<Slave> >/Try<PID<Slave>> and the following?
- Guangya Liu
On 十一月 24, 2015, 4:54 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40654/
> -----------------------------------------------------------
>
> (Updated 十一月 24, 2015, 4:54 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up usage of `CreateSlaveFlags()` in a test file.
>
>
> Diffs
> -----
>
> src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95
>
> Diff: https://reviews.apache.org/r/40654/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in
a test file.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40654/#review107983
-----------------------------------------------------------
Ship it!
There are also other files need to be updated, but I think that we can update one by one.
- Guangya Liu
On 十一月 25, 2015, 2:32 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40654/
> -----------------------------------------------------------
>
> (Updated 十一月 25, 2015, 2:32 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up usage of `CreateSlaveFlags()` in a test file.
>
>
> Diffs
> -----
>
> src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95
>
> Diff: https://reviews.apache.org/r/40654/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in
a test file.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40654/#review108168
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Nov. 25, 2015, 2:32 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40654/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 2:32 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up usage of `CreateSlaveFlags()` in a test file.
>
>
> Diffs
> -----
>
> src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95
>
> Diff: https://reviews.apache.org/r/40654/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in
a test file.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40654/
-----------------------------------------------------------
(Updated Nov. 25, 2015, 2:32 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Rebase.
Repository: mesos
Description
-------
Cleaned up usage of `CreateSlaveFlags()` in a test file.
Diffs (updated)
-----
src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95
Diff: https://reviews.apache.org/r/40654/diff/
Testing
-------
make check
Thanks,
Neil Conway