You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/06/09 17:41:40 UTC

[GitHub] [helix] xyuanlu commented on a change in pull request #1787: Support currentState format for partitionAssignment

xyuanlu commented on a change in pull request #1787:
URL: https://github.com/apache/helix/pull/1787#discussion_r648531571



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ResourceAssignmentOptimizerAccessor.java
##########
@@ -104,11 +107,16 @@ public AssignmentResult() {
     Map<String, String> swapInstances;
   }
 
+  private static final String IDEAL_STATE_FORMAT = "IdealStateFormat";
+  private static final String CURRENT_STATE_FORMAT = "CurrentStateFormat";

Review comment:
       TFTR. Good suggestion. Updated. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org