You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@yetus.apache.org by "Kengo Seki (JIRA)" <ji...@apache.org> on 2015/11/02 07:35:27 UTC
[jira] [Updated] (YETUS-134) asflicense test should not be always
added
[ https://issues.apache.org/jira/browse/YETUS-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kengo Seki updated YETUS-134:
-----------------------------
Attachment: YETUS-134.00.patch
Attaching a patch. Before applying it:
{code}
[sekikn@mobile yetus]$ precommit/test-patch.sh --build-tool=nobuild --plugins=all --resetrepo YETUS-78
(snip)
|| Subsystem || Report/Notes ||
============================================================================
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12769208/YETUS-78.02.patch |
| Optional Tests | asflicense shellcheck |
(snip)
{code}
After applying:
{code}
[sekikn@mobile yetus]$ precommit/smart-apply-patch.sh ~/YETUS-134.00.patch
(snip)
[sekikn@mobile yetus]$ precommit/test-patch.sh --build-tool=nobuild --dirty-workspace --plugins=all YETUS-78
(snip)
|| Subsystem || Report/Notes ||
============================================================================
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12769208/YETUS-78.02.patch |
| Optional Tests | shellcheck |
(snip)
{code}
> asflicense test should not be always added
> ------------------------------------------
>
> Key: YETUS-134
> URL: https://issues.apache.org/jira/browse/YETUS-134
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
> Reporter: Kengo Seki
> Attachments: YETUS-134.00.patch
>
>
> This code is intended to determine if asflicense test should be enabled or not,
> {code:title=dev-support/test-patch.d/asflicense.sh}
> 36 case ${BUILDTOOL} in
> 37 ant|gradle|maven)
> 38 add_test asflicense
> 39 ;;
> 40 *)
> 41 if [[ -f "${ASFLICENSE_RAT_JAR}" ]]; then
> 42 add_test asflicense
> 43 fi
> 44 ;;
> 45 esac
> {code}
> but it won't work as expected because of
> {code:title=dev-support/test-patch.d/asflicense.sh}
> 19 add_test asflicense
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)