You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Mahadev konar (Commented) (JIRA)" <ji...@apache.org> on 2012/02/06 07:16:05 UTC

[jira] [Commented] (ZOOKEEPER-1352) server.InvalidSnapshotTest is using connection timeouts that are too short

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201062#comment-13201062 ] 

Mahadev konar commented on ZOOKEEPER-1352:
------------------------------------------

Good change to have. Since its just fixing tests, Ill commit this into all 3 branches.
                
> server.InvalidSnapshotTest is using connection timeouts that are too short
> --------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1352
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1352
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 3.3.4
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.5, 3.4.3, 3.5.0
>
>         Attachments: ZOOKEEPER-1352_br33.patch, ZOOKEEPER-1352_br34.patch, ZOOKEEPER-1352_trunk.patch
>
>
> InvalidSnapshotTest is using connection timeouts that are too short, see this false failure:
> https://builds.apache.org/job/ZooKeeper_branch33_solaris/65/testReport/junit/org.apache.zookeeper.server/InvalidSnapshotTest/testInvalidSnapshot/
> {noformat}
> org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /invalidsnap-0
> 	at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
> 	at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
> 	at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:643)
> 	at org.apache.zookeeper.server.InvalidSnapshotTest.testInvalidSnapshot(InvalidSnapshotTest.java:71)
> {noformat}
> Also in looking at the test itself it could use some cleanup (reuse features from ClientBase test utils)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira