You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shardingsphere.apache.org by Juan Pan <pa...@apache.org> on 2020/01/09 06:20:48 UTC
[DISCUSS] Optimization for Sharing Parser with Antlr Visitor
Hi folks,
It is not common practice and prone to low performance that `ExtractorEngine` and `FillerEngine` are used to get final SQL parsed result based on AST generated by ANTLR at present. Upon investigation, we would like to replace them with ANTLR visitor.
It is scheduled as a long-term task and a big change for our 5.x release, and currently i am trying to do some basic work for our new branch[1]. After the groundwork (Roughly estimated time is one week. ) is basically laid, we would like to welcome anyone who is interested in it to join us for this wonderful sharding parser.
Please watch this thread for follow-up. What’s more, welcome your any comment and suggestion!
[1] https://github.com/apache/incubator-shardingsphere/tree/sharding-parser-5.x
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
Re: [DISCUSS] Optimization for Sharing Parser with Antlr Visitor
Posted by Juan Pan <pa...@apache.org>.
Here are some detail,
1. Finish parser refactoring of MySQL
It is better to finish the following child tasks(from easy level to hard level) in order before 15th Feb.
1.1 TCLStatement.g4 and DCLStatement.g4
1.2 DALStatement.g4 and DDLStatement.g4
1.3 DMLStatement.g4
2. Finish parser refactoring of Oracle, PostgreSQL, SQLServer, SQL92
After completing the above task, those branches could begin simultaneously.
This plan is a huge one, and we would like to welcome more people to join. Thanks
Trista
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 01/17/2020 16:15，Nicholas<th...@gmail.com> wrote：
Hi Juan,
About "Optimization for Sharing Parser with Antlr Visitor", does the refactor have any roadmap or subtask that provides community developers to choose for contribution? This could attract more developers to contribute to parser refactoring.
Thanks,
Nicholas
On 2020/01/09 06:20:48, "Juan Pan" <pa...@apache.org> wrote:
Hi folks,
It is not common practice and prone to low performance that `ExtractorEngine` and `FillerEngine` are used to get final SQL parsed result based on AST generated by ANTLR at present. Upon investigation, we would like to replace them with ANTLR visitor.
It is scheduled as a long-term task and a big change for our 5.x release, and currently i am trying to do some basic work for our new branch[1]. After the groundwork (Roughly estimated time is one week. ) is basically laid, we would like to welcome anyone who is interested in it to join us for this wonderful sharding parser.
Please watch this thread for follow-up. What’s more, welcome your any comment and suggestion!
[1] https://github.com/apache/incubator-shardingsphere/tree/sharding-parser-5.x
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
Re: [DISCUSS] Optimization for Sharing Parser with Antlr Visitor
Posted by Nicholas <th...@gmail.com>.
Hi Juan,
About "Optimization for Sharing Parser with Antlr Visitor", does the refactor have any roadmap or subtask that provides community developers to choose for contribution? This could attract more developers to contribute to parser refactoring.
Thanks,
Nicholas
On 2020/01/09 06:20:48, "Juan Pan" <pa...@apache.org> wrote:
> Hi folks,
>
>
> It is not common practice and prone to low performance that `ExtractorEngine` and `FillerEngine` are used to get final SQL parsed result based on AST generated by ANTLR at present. Upon investigation, we would like to replace them with ANTLR visitor.
>
>
> It is scheduled as a long-term task and a big change for our 5.x release, and currently i am trying to do some basic work for our new branch[1]. After the groundwork (Roughly estimated time is one week. ) is basically laid, we would like to welcome anyone who is interested in it to join us for this wonderful sharding parser.
>
>
> Please watch this thread for follow-up. What’s more, welcome your any comment and suggestion!
>
>
>
>
> [1] https://github.com/apache/incubator-shardingsphere/tree/sharding-parser-5.x
>
>
>
>
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
Re: [DISCUSS] Optimization for Sharing Parser with Antlr Visitor
Posted by 蒋晓峰 <th...@gmail.com>.
Hi Juan,
Sorry for the late reply. This weekend I would like to support the
change for DDLStatement.
Thanks,
Nicholas Jiang
On Fri, Feb 7, 2020 at 11:51 AM Juan Pan <pa...@apache.org> wrote:
> Hi
>
>
> Provide feedback on task progress, refer to [1] to learn more. Welcome
> your any suggestion.
>
>
> [1]
> https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-583220969
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
> On 02/2/2020 18:04，Juan Pan<pa...@apache.org> wrote：
> Hi everyone,
>
>
> Thanks for your attention.
> I am glad to tell the community that this long-term task has been on the
> right way and made some progress. Please refer to [1] for its detailed
> progress.
> Many thanks for the contributions from SteNicholas, dongzl, jingshanglu,
> tianbin1001 and beijing-penguin and your effort make this progress
> possible.
>
>
> However there are many optimization and work for community to do for this
> task, so we welcome everyone interested in it to join us!
>
>
> Hope your good health during this special Chinese new year.
>
>
> - [1]
> https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-581108911
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
> On 01/9/2020 14:20，Juan Pan<pa...@apache.org> wrote：
> Hi folks,
>
>
> It is not common practice and prone to low performance that
> `ExtractorEngine` and `FillerEngine` are used to get final SQL parsed
> result based on AST generated by ANTLR at present. Upon investigation, we
> would like to replace them with ANTLR visitor.
>
>
> It is scheduled as a long-term task and a big change for our 5.x release,
> and currently i am trying to do some basic work for our new branch[1].
> After the groundwork (Roughly estimated time is one week. ) is basically
> laid, we would like to welcome anyone who is interested in it to join us
> for this wonderful sharding parser.
>
>
> Please watch this thread for follow-up. What’s more, welcome your any
> comment and suggestion!
>
>
>
>
> [1]
> https://github.com/apache/incubator-shardingsphere/tree/sharding-parser-5.x
>
>
>
>
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
Re: [DISCUSS] Optimization for Sharing Parser with Antlr Visitor
Posted by 蒋晓峰 <th...@gmail.com>.
Hi Juan,
I'm very willing to wait for your ping. Any time you ping me, I would
like to be assigned for something about this issue.
Thanks,
Nicholas
On Mon, Feb 17, 2020 at 11:50 AM Juan Pan <pa...@apache.org> wrote:
> Hi Nicholas,
> Very appreciated for your close follow-up for this thread.
> You can learn more about the most recent progress of this task here [1].
> I am handling this issue, and when i need your assistance, could i ping
> you then?
>
>
> Regards,
> Trista
>
>
> [1] https://github.com/apache/incubator-shardingsphere/issues/4335
>
>
>
>
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
> On 02/16/2020 22:16，蒋晓峰<th...@gmail.com> wrote：
> Hi Juan,
> What's the plan of improvements for new MySQL parser? I found no email
> including something about improvements for new MySQL parser.
>
> Thanks,
> Nicholas
>
> On Thu, Feb 13, 2020 at 3:17 PM Juan Pan <pa...@apache.org> wrote:
>
> Hi everyone,
>
>
> Good news for us that we basically finish the parser refactoring for
> MySQL.[1]
> Specially thanks for @terrymanu @SteNicholas @dongzl @tianbin1001
> @beijing-penguin!
>
>
> Our next step is to do some improvements for new MySQL parser, and
> continue working on parser refactoring for other databases.
> So Veterans, would you like to move on? Additionally, we welcome anyone to
> join us for parser integrated tests!
> Please reply to give your comment.
>
>
> Best wishes,
>
>
> [1] https://github.com/apache/incubator-shardingsphere/issues/3914
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
> On 02/12/2020 10:32，Juan Pan<pa...@apache.org> wrote：
> Kind reminder,
> If you could not edit issue, please be free to contact any committer or
> reply this email then i will provide you any help.
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
> On 02/12/2020 10:25，Juan Pan<pa...@apache.org> wrote：
> Hi everyone,
>
>
> The task of `DML SQL Visitor` has made some progress, and i updated the
> status of issue #3914.
> However, i am unclear of others’ progress, any changes, could you please
> update the issue[1][2]?
>
>
> [1]
>
> https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-581108911
> [2]
>
> https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-583220969
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
> On 02/7/2020 11:51，Juan Pan<pa...@apache.org> wrote：
> Hi
>
>
> Provide feedback on task progress, refer to [1] to learn more. Welcome
> your any suggestion.
>
>
> [1]
>
> https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-583220969
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
> On 02/2/2020 18:04，Juan Pan<pa...@apache.org> wrote：
> Hi everyone,
>
>
> Thanks for your attention.
> I am glad to tell the community that this long-term task has been on the
> right way and made some progress. Please refer to [1] for its detailed
> progress.
> Many thanks for the contributions from SteNicholas, dongzl, jingshanglu,
> tianbin1001 and beijing-penguin and your effort make this progress
> possible.
>
>
> However there are many optimization and work for community to do for this
> task, so we welcome everyone interested in it to join us!
>
>
> Hope your good health during this special Chinese new year.
>
>
> - [1]
>
> https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-581108911
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
> On 01/9/2020 14:20，Juan Pan<pa...@apache.org> wrote：
> Hi folks,
>
>
> It is not common practice and prone to low performance that
> `ExtractorEngine` and `FillerEngine` are used to get final SQL parsed
> result based on AST generated by ANTLR at present. Upon investigation, we
> would like to replace them with ANTLR visitor.
>
>
> It is scheduled as a long-term task and a big change for our 5.x release,
> and currently i am trying to do some basic work for our new branch[1].
> After the groundwork (Roughly estimated time is one week. ) is basically
> laid, we would like to welcome anyone who is interested in it to join us
> for this wonderful sharding parser.
>
>
> Please watch this thread for follow-up. What’s more, welcome your any
> comment and suggestion!
>
>
>
>
> [1]
> https://github.com/apache/incubator-shardingsphere/tree/sharding-parser-5.x
>
>
>
>
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
>
Re: [DISCUSS] Optimization for Sharing Parser with Antlr Visitor
Posted by Juan Pan <pa...@apache.org>.
Hi Nicholas,
Very appreciated for your close follow-up for this thread.
You can learn more about the most recent progress of this task here [1].
I am handling this issue, and when i need your assistance, could i ping you then?
Regards,
Trista
[1] https://github.com/apache/incubator-shardingsphere/issues/4335
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 02/16/2020 22:16，蒋晓峰<th...@gmail.com> wrote：
Hi Juan,
What's the plan of improvements for new MySQL parser? I found no email
including something about improvements for new MySQL parser.
Thanks,
Nicholas
On Thu, Feb 13, 2020 at 3:17 PM Juan Pan <pa...@apache.org> wrote:
Hi everyone,
Good news for us that we basically finish the parser refactoring for
MySQL.[1]
Specially thanks for @terrymanu @SteNicholas @dongzl @tianbin1001
@beijing-penguin!
Our next step is to do some improvements for new MySQL parser, and
continue working on parser refactoring for other databases.
So Veterans, would you like to move on? Additionally, we welcome anyone to
join us for parser integrated tests!
Please reply to give your comment.
Best wishes,
[1] https://github.com/apache/incubator-shardingsphere/issues/3914
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 02/12/2020 10:32，Juan Pan<pa...@apache.org> wrote：
Kind reminder,
If you could not edit issue, please be free to contact any committer or
reply this email then i will provide you any help.
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 02/12/2020 10:25，Juan Pan<pa...@apache.org> wrote：
Hi everyone,
The task of `DML SQL Visitor` has made some progress, and i updated the
status of issue #3914.
However, i am unclear of others’ progress, any changes, could you please
update the issue[1][2]?
[1]
https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-581108911
[2]
https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-583220969
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 02/7/2020 11:51，Juan Pan<pa...@apache.org> wrote：
Hi
Provide feedback on task progress, refer to [1] to learn more. Welcome
your any suggestion.
[1]
https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-583220969
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 02/2/2020 18:04，Juan Pan<pa...@apache.org> wrote：
Hi everyone,
Thanks for your attention.
I am glad to tell the community that this long-term task has been on the
right way and made some progress. Please refer to [1] for its detailed
progress.
Many thanks for the contributions from SteNicholas, dongzl, jingshanglu,
tianbin1001 and beijing-penguin and your effort make this progress
possible.
However there are many optimization and work for community to do for this
task, so we welcome everyone interested in it to join us!
Hope your good health during this special Chinese new year.
- [1]
https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-581108911
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 01/9/2020 14:20，Juan Pan<pa...@apache.org> wrote：
Hi folks,
It is not common practice and prone to low performance that
`ExtractorEngine` and `FillerEngine` are used to get final SQL parsed
result based on AST generated by ANTLR at present. Upon investigation, we
would like to replace them with ANTLR visitor.
It is scheduled as a long-term task and a big change for our 5.x release,
and currently i am trying to do some basic work for our new branch[1].
After the groundwork (Roughly estimated time is one week. ) is basically
laid, we would like to welcome anyone who is interested in it to join us
for this wonderful sharding parser.
Please watch this thread for follow-up. What’s more, welcome your any
comment and suggestion!
[1]
https://github.com/apache/incubator-shardingsphere/tree/sharding-parser-5.x
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
Re: [DISCUSS] Optimization for Sharing Parser with Antlr Visitor
Posted by 蒋晓峰 <th...@gmail.com>.
Hi Juan,
What's the plan of improvements for new MySQL parser? I found no email
including something about improvements for new MySQL parser.
Thanks,
Nicholas
On Thu, Feb 13, 2020 at 3:17 PM Juan Pan <pa...@apache.org> wrote:
> Hi everyone,
>
>
> Good news for us that we basically finish the parser refactoring for
> MySQL.[1]
> Specially thanks for @terrymanu @SteNicholas @dongzl @tianbin1001
> @beijing-penguin!
>
>
> Our next step is to do some improvements for new MySQL parser, and
> continue working on parser refactoring for other databases.
> So Veterans, would you like to move on? Additionally, we welcome anyone to
> join us for parser integrated tests!
> Please reply to give your comment.
>
>
> Best wishes,
>
>
> [1] https://github.com/apache/incubator-shardingsphere/issues/3914
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
> On 02/12/2020 10:32，Juan Pan<pa...@apache.org> wrote：
> Kind reminder,
> If you could not edit issue, please be free to contact any committer or
> reply this email then i will provide you any help.
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
> On 02/12/2020 10:25，Juan Pan<pa...@apache.org> wrote：
> Hi everyone,
>
>
> The task of `DML SQL Visitor` has made some progress, and i updated the
> status of issue #3914.
> However, i am unclear of others’ progress, any changes, could you please
> update the issue[1][2]?
>
>
> [1]
> https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-581108911
> [2]
> https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-583220969
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
> On 02/7/2020 11:51，Juan Pan<pa...@apache.org> wrote：
> Hi
>
>
> Provide feedback on task progress, refer to [1] to learn more. Welcome
> your any suggestion.
>
>
> [1]
> https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-583220969
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
> On 02/2/2020 18:04，Juan Pan<pa...@apache.org> wrote：
> Hi everyone,
>
>
> Thanks for your attention.
> I am glad to tell the community that this long-term task has been on the
> right way and made some progress. Please refer to [1] for its detailed
> progress.
> Many thanks for the contributions from SteNicholas, dongzl, jingshanglu,
> tianbin1001 and beijing-penguin and your effort make this progress
> possible.
>
>
> However there are many optimization and work for community to do for this
> task, so we welcome everyone interested in it to join us!
>
>
> Hope your good health during this special Chinese new year.
>
>
> - [1]
> https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-581108911
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
> On 01/9/2020 14:20，Juan Pan<pa...@apache.org> wrote：
> Hi folks,
>
>
> It is not common practice and prone to low performance that
> `ExtractorEngine` and `FillerEngine` are used to get final SQL parsed
> result based on AST generated by ANTLR at present. Upon investigation, we
> would like to replace them with ANTLR visitor.
>
>
> It is scheduled as a long-term task and a big change for our 5.x release,
> and currently i am trying to do some basic work for our new branch[1].
> After the groundwork (Roughly estimated time is one week. ) is basically
> laid, we would like to welcome anyone who is interested in it to join us
> for this wonderful sharding parser.
>
>
> Please watch this thread for follow-up. What’s more, welcome your any
> comment and suggestion!
>
>
>
>
> [1]
> https://github.com/apache/incubator-shardingsphere/tree/sharding-parser-5.x
>
>
>
>
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
Re:[DISCUSS] Optimization for Sharing Parser with Antlr Visitor
Posted by Juan Pan <pa...@apache.org>.
Hi everyone,
Good news for us that we basically finish the parser refactoring for MySQL.[1]
Specially thanks for @terrymanu @SteNicholas @dongzl @tianbin1001 @beijing-penguin!
Our next step is to do some improvements for new MySQL parser, and continue working on parser refactoring for other databases.
So Veterans, would you like to move on? Additionally, we welcome anyone to join us for parser integrated tests!
Please reply to give your comment.
Best wishes,
[1] https://github.com/apache/incubator-shardingsphere/issues/3914
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 02/12/2020 10:32，Juan Pan<pa...@apache.org> wrote：
Kind reminder,
If you could not edit issue, please be free to contact any committer or reply this email then i will provide you any help.
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 02/12/2020 10:25，Juan Pan<pa...@apache.org> wrote：
Hi everyone,
The task of `DML SQL Visitor` has made some progress, and i updated the status of issue #3914.
However, i am unclear of others’ progress, any changes, could you please update the issue[1][2]?
[1] https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-581108911
[2] https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-583220969
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 02/7/2020 11:51，Juan Pan<pa...@apache.org> wrote：
Hi
Provide feedback on task progress, refer to [1] to learn more. Welcome your any suggestion.
[1] https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-583220969
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 02/2/2020 18:04，Juan Pan<pa...@apache.org> wrote：
Hi everyone,
Thanks for your attention.
I am glad to tell the community that this long-term task has been on the right way and made some progress. Please refer to [1] for its detailed progress.
Many thanks for the contributions from SteNicholas, dongzl, jingshanglu, tianbin1001 and beijing-penguin and your effort make this progress possible.
However there are many optimization and work for community to do for this task, so we welcome everyone interested in it to join us!
Hope your good health during this special Chinese new year.
- [1] https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-581108911
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 01/9/2020 14:20，Juan Pan<pa...@apache.org> wrote：
Hi folks,
It is not common practice and prone to low performance that `ExtractorEngine` and `FillerEngine` are used to get final SQL parsed result based on AST generated by ANTLR at present. Upon investigation, we would like to replace them with ANTLR visitor.
It is scheduled as a long-term task and a big change for our 5.x release, and currently i am trying to do some basic work for our new branch[1]. After the groundwork (Roughly estimated time is one week. ) is basically laid, we would like to welcome anyone who is interested in it to join us for this wonderful sharding parser.
Please watch this thread for follow-up. What’s more, welcome your any comment and suggestion!
[1] https://github.com/apache/incubator-shardingsphere/tree/sharding-parser-5.x
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
Re:[DISCUSS] Optimization for Sharing Parser with Antlr Visitor
Posted by Juan Pan <pa...@apache.org>.
Kind reminder,
If you could not edit issue, please be free to contact any committer or reply this email then i will provide you any help.
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 02/12/2020 10:25，Juan Pan<pa...@apache.org> wrote：
Hi everyone,
The task of `DML SQL Visitor` has made some progress, and i updated the status of issue #3914.
However, i am unclear of others’ progress, any changes, could you please update the issue[1][2]?
[1] https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-581108911
[2] https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-583220969
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 02/7/2020 11:51，Juan Pan<pa...@apache.org> wrote：
Hi
Provide feedback on task progress, refer to [1] to learn more. Welcome your any suggestion.
[1] https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-583220969
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 02/2/2020 18:04，Juan Pan<pa...@apache.org> wrote：
Hi everyone,
Thanks for your attention.
I am glad to tell the community that this long-term task has been on the right way and made some progress. Please refer to [1] for its detailed progress.
Many thanks for the contributions from SteNicholas, dongzl, jingshanglu, tianbin1001 and beijing-penguin and your effort make this progress possible.
However there are many optimization and work for community to do for this task, so we welcome everyone interested in it to join us!
Hope your good health during this special Chinese new year.
- [1] https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-581108911
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 01/9/2020 14:20，Juan Pan<pa...@apache.org> wrote：
Hi folks,
It is not common practice and prone to low performance that `ExtractorEngine` and `FillerEngine` are used to get final SQL parsed result based on AST generated by ANTLR at present. Upon investigation, we would like to replace them with ANTLR visitor.
It is scheduled as a long-term task and a big change for our 5.x release, and currently i am trying to do some basic work for our new branch[1]. After the groundwork (Roughly estimated time is one week. ) is basically laid, we would like to welcome anyone who is interested in it to join us for this wonderful sharding parser.
Please watch this thread for follow-up. What’s more, welcome your any comment and suggestion!
[1] https://github.com/apache/incubator-shardingsphere/tree/sharding-parser-5.x
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
Re:[DISCUSS] Optimization for Sharing Parser with Antlr Visitor
Posted by Juan Pan <pa...@apache.org>.
Hi everyone,
The task of `DML SQL Visitor` has made some progress, and i updated the status of issue #3914.
However, i am unclear of others’ progress, any changes, could you please update the issue[1][2]?
[1] https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-581108911
[2] https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-583220969
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 02/7/2020 11:51，Juan Pan<pa...@apache.org> wrote：
Hi
Provide feedback on task progress, refer to [1] to learn more. Welcome your any suggestion.
[1] https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-583220969
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 02/2/2020 18:04，Juan Pan<pa...@apache.org> wrote：
Hi everyone,
Thanks for your attention.
I am glad to tell the community that this long-term task has been on the right way and made some progress. Please refer to [1] for its detailed progress.
Many thanks for the contributions from SteNicholas, dongzl, jingshanglu, tianbin1001 and beijing-penguin and your effort make this progress possible.
However there are many optimization and work for community to do for this task, so we welcome everyone interested in it to join us!
Hope your good health during this special Chinese new year.
- [1] https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-581108911
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 01/9/2020 14:20，Juan Pan<pa...@apache.org> wrote：
Hi folks,
It is not common practice and prone to low performance that `ExtractorEngine` and `FillerEngine` are used to get final SQL parsed result based on AST generated by ANTLR at present. Upon investigation, we would like to replace them with ANTLR visitor.
It is scheduled as a long-term task and a big change for our 5.x release, and currently i am trying to do some basic work for our new branch[1]. After the groundwork (Roughly estimated time is one week. ) is basically laid, we would like to welcome anyone who is interested in it to join us for this wonderful sharding parser.
Please watch this thread for follow-up. What’s more, welcome your any comment and suggestion!
[1] https://github.com/apache/incubator-shardingsphere/tree/sharding-parser-5.x
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
Re:[DISCUSS] Optimization for Sharing Parser with Antlr Visitor
Posted by Juan Pan <pa...@apache.org>.
Hi
Provide feedback on task progress, refer to [1] to learn more. Welcome your any suggestion.
[1] https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-583220969
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 02/2/2020 18:04，Juan Pan<pa...@apache.org> wrote：
Hi everyone,
Thanks for your attention.
I am glad to tell the community that this long-term task has been on the right way and made some progress. Please refer to [1] for its detailed progress.
Many thanks for the contributions from SteNicholas, dongzl, jingshanglu, tianbin1001 and beijing-penguin and your effort make this progress possible.
However there are many optimization and work for community to do for this task, so we welcome everyone interested in it to join us!
Hope your good health during this special Chinese new year.
- [1] https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-581108911
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 01/9/2020 14:20，Juan Pan<pa...@apache.org> wrote：
Hi folks,
It is not common practice and prone to low performance that `ExtractorEngine` and `FillerEngine` are used to get final SQL parsed result based on AST generated by ANTLR at present. Upon investigation, we would like to replace them with ANTLR visitor.
It is scheduled as a long-term task and a big change for our 5.x release, and currently i am trying to do some basic work for our new branch[1]. After the groundwork (Roughly estimated time is one week. ) is basically laid, we would like to welcome anyone who is interested in it to join us for this wonderful sharding parser.
Please watch this thread for follow-up. What’s more, welcome your any comment and suggestion!
[1] https://github.com/apache/incubator-shardingsphere/tree/sharding-parser-5.x
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
Re:[DISCUSS] Optimization for Sharing Parser with Antlr Visitor
Posted by Juan Pan <pa...@apache.org>.
Hi everyone,
Thanks for your attention.
I am glad to tell the community that this long-term task has been on the right way and made some progress. Please refer to [1] for its detailed progress.
Many thanks for the contributions from SteNicholas, dongzl, jingshanglu, tianbin1001 and beijing-penguin and your effort make this progress possible.
However there are many optimization and work for community to do for this task, so we welcome everyone interested in it to join us!
Hope your good health during this special Chinese new year.
- [1] https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-581108911
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 01/9/2020 14:20，Juan Pan<pa...@apache.org> wrote：
Hi folks,
It is not common practice and prone to low performance that `ExtractorEngine` and `FillerEngine` are used to get final SQL parsed result based on AST generated by ANTLR at present. Upon investigation, we would like to replace them with ANTLR visitor.
It is scheduled as a long-term task and a big change for our 5.x release, and currently i am trying to do some basic work for our new branch[1]. After the groundwork (Roughly estimated time is one week. ) is basically laid, we would like to welcome anyone who is interested in it to join us for this wonderful sharding parser.
Please watch this thread for follow-up. What’s more, welcome your any comment and suggestion!
[1] https://github.com/apache/incubator-shardingsphere/tree/sharding-parser-5.x
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
Re:[DISCUSS] Optimization for Sharing Parser with Antlr Visitor
Posted by Juan Pan <pa...@apache.org>.
Hi folks,
Groundwork for our new parser has already finished ahead of schedule, mainly including adding visitor entrance classes for different databases and creating new parsed integrated test architecture.
At present, we would like to invite anyone who is experienced or interested in ANTLR and SQL parser to join this long-term task for our 5.x release!
Welcome step forward and give your comment if you want to be part of this important task. :-)
Best wishes,
Trista
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 01/9/2020 14:20，Juan Pan<pa...@apache.org> wrote：
Hi folks,
It is not common practice and prone to low performance that `ExtractorEngine` and `FillerEngine` are used to get final SQL parsed result based on AST generated by ANTLR at present. Upon investigation, we would like to replace them with ANTLR visitor.
It is scheduled as a long-term task and a big change for our 5.x release, and currently i am trying to do some basic work for our new branch[1]. After the groundwork (Roughly estimated time is one week. ) is basically laid, we would like to welcome anyone who is interested in it to join us for this wonderful sharding parser.
Please watch this thread for follow-up. What’s more, welcome your any comment and suggestion!
[1] https://github.com/apache/incubator-shardingsphere/tree/sharding-parser-5.x
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
Re: [DISCUSS] Optimization for Sharing Parser with Antlr Visitor
Posted by "zhangliang@apache.org" <zh...@apache.org>.
Yes, using visitor is a standard way to visit the AST, it is better than
previous way. Please go ahead.
------------------
Liang Zhang (John)
Apache ShardingSphere & Dubbo
Juan Pan <pa...@apache.org> 于2020年1月9日周四 下午2:21写道：
> Hi folks,
>
>
> It is not common practice and prone to low performance that
> `ExtractorEngine` and `FillerEngine` are used to get final SQL parsed
> result based on AST generated by ANTLR at present. Upon investigation, we
> would like to replace them with ANTLR visitor.
>
>
> It is scheduled as a long-term task and a big change for our 5.x release,
> and currently i am trying to do some basic work for our new branch[1].
> After the groundwork (Roughly estimated time is one week. ) is basically
> laid, we would like to welcome anyone who is interested in it to join us
> for this wonderful sharding parser.
>
>
> Please watch this thread for follow-up. What’s more, welcome your any
> comment and suggestion!
>
>
>
>
> [1]
> https://github.com/apache/incubator-shardingsphere/tree/sharding-parser-5.x
>
>
>
>
>
>
> Juan Pan (Trista)
>
> Senior DBA & PPMC of Apache ShardingSphere(Incubating)
> E-mail: panjuan@apache.org
>
>
>
>
Re:[DISCUSS] Optimization for Sharing Parser with Antlr Visitor
Posted by Juan Pan <pa...@apache.org>.
FYI, refer to [1] to learn the details more.
[1] https://github.com/apache/incubator-shardingsphere/issues/3914
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org
On 01/9/2020 14:20，Juan Pan<pa...@apache.org> wrote：
Hi folks,
It is not common practice and prone to low performance that `ExtractorEngine` and `FillerEngine` are used to get final SQL parsed result based on AST generated by ANTLR at present. Upon investigation, we would like to replace them with ANTLR visitor.
It is scheduled as a long-term task and a big change for our 5.x release, and currently i am trying to do some basic work for our new branch[1]. After the groundwork (Roughly estimated time is one week. ) is basically laid, we would like to welcome anyone who is interested in it to join us for this wonderful sharding parser.
Please watch this thread for follow-up. What’s more, welcome your any comment and suggestion!
[1] https://github.com/apache/incubator-shardingsphere/tree/sharding-parser-5.x
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panjuan@apache.org